third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp ('k') | third_party/WebKit/Source/web/InspectorOverlay.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

index ff6934ced067a8f8cad0595cb3db9bcb6a634a39..93d7cf37e4421a7a74f26b59dc9d025c54ca50fb 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp

@@ -224,8 +224,13 @@ std::unique_ptr<protocol::Value> toProtocolValue(v8::Local<v8::Context> context,

return protocol::Value::null();

if (value->IsBoolean())

return protocol::FundamentalValue::create(value.As<v8::Boolean>()->Value());

- if (value->IsNumber())

- return protocol::FundamentalValue::create(value.As<v8::Number>()->Value());

+ if (value->IsNumber()) {

+ double doubleValue = value.As<v8::Number>()->Value();

+ int intValue = static_cast<int>(doubleValue);

+ if (intValue == doubleValue)

+ return protocol::FundamentalValue::create(intValue);

+ return protocol::FundamentalValue::create(doubleValue);

+ }

if (value->IsString())

return protocol::StringValue::create(toProtocolString(value.As<v8::String>()));

if (value->IsArray()) {