third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/String16STL.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/ValueConversions.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h b/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

index bd937b80bf8afa5c326a35b2178ba94bc579c015..19c56256f0dec481d1c3255351a1d19e9cee65c6 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/String16WTF.h

@@ -42,7 +42,7 @@ public:

~String16() { }

- static String16 number(int i) { return String::number(i); }

+ static String16 fromInteger(int i) { return String::number(i); }

static String16 fromDouble(double number) { return Decimal::fromDouble(number).toString(); }

static String16 fromDoubleFixedPrecision(double number, int precision) { return String::numberToStringFixedWidth(number, precision); }