third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/ParserTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp b/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp

index 1c267f871a96b2f56ce26cc07335873c37609b22..4193108b279162d232f681cdd0f74ff250c16fff 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Parser.cpp

@@ -382,7 +382,11 @@ std::unique_ptr<Value> buildValue(const UChar* start, const UChar* end, const UC

double value = String16::charactersToDouble(tokenStart, tokenEnd - tokenStart, &ok);

if (!ok)

return nullptr;

- result = FundamentalValue::create(value);

+ int number = static_cast<int>(value);

+ if (number == value)

+ result = FundamentalValue::create(number);

+ else

+ result = FundamentalValue::create(value);

break;

}

case StringLiteral: {