third_party/WebKit/Source/platform/inspector_protocol/Array.h - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Array.h

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/device_orientation/DeviceOrientationInspectorAgent.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/Array.h

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Array.h b/third_party/WebKit/Source/platform/inspector_protocol/Array.h

index 16563af15d20b597c3eda255124bcd05b1745503..d92af3a5ed7d05259a52304c5f86a6f407cdda82 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/Array.h

+++ b/third_party/WebKit/Source/platform/inspector_protocol/Array.h

@@ -34,7 +34,7 @@ public:

errors->push();

std::unique_ptr<Array<T>> result(new Array<T>());

for (size_t i = 0; i < array->size(); ++i) {

- errors->setName(String16::number(i));

+ errors->setName(String16::fromInteger(i));

T item = FromValue<T>::parse(array->at(i), errors);

result->m_vector.push_back(item);

}

@@ -95,7 +95,7 @@ public:

std::unique_ptr<Array<T>> result(new Array<T>());

errors->push();

for (size_t i = 0; i < array->size(); ++i) {

- errors->setName(String16::number(i));

+ errors->setName(String16::fromInteger(i));

std::unique_ptr<T> item = FromValue<T>::parse(array->at(i), errors);

result->m_vector.push_back(std::move(item));

}