third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py - Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

Issue 2151083002: DevTools: explicitly differentiate ints vs doubles in the protocol bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: lcean Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/inspector_protocol/Array.h ('k') | third_party/WebKit/Source/platform/inspector_protocol/DispatcherBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

diff --git a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

index 4c11161a3cad63d9f3db58a848407b36d37cfeb7..3dc3706e006d79823b71fa626f967b5fb703be09 100644

--- a/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

+++ b/third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py

@@ -215,8 +215,8 @@ def create_primitive_type_definition(type):

"boolean": "false"

}

jsontypes = {

- "number": "TypeNumber",

- "integer": "TypeNumber",

+ "number": "TypeDouble",

+ "integer": "TypeInteger",

"boolean": "TypeBoolean",

}

return {