Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed)

Created:
4 years, 7 months ago by charliea (OOO until 10-5)
Modified:
4 years, 7 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@polymer10-migration
Target Ref:
refs/heads/polymer10-migration
Project:
catapult
Visibility:
Public.

Description

[polymer] Switches .appendChild() to Polymer.dom()...appendChild() TBR=aiolos@chromium.org NOTRY=true NOPRESUBMIT=true BUG=catapult:#2285 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/37b678d819c720423e29134b9ea1ea743c581d02

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+420 lines, -400 lines) Patch
M tracing/tracing/base/base.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/base/unittest/html_test_results.html View 1 1 chunk +6 lines, -6 lines 0 comments Download
M tracing/tracing/base/unittest/interactive_test_runner.html View 1 5 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/base/unittest/suite_loader.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/core/test_utils.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/importer/import.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/trace2html.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/analysis_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/container_memory_dump_sub_view.html View 3 chunks +9 lines, -8 lines 0 comments Download
M tracing/tracing/ui/analysis/container_memory_dump_sub_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/frame_power_usage_chart.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/generic_object_view.html View 2 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_header_pane.html View 2 chunks +18 lines, -17 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html View 2 chunks +18 lines, -18 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_sub_view_util.html View 5 chunks +15 lines, -12 lines 0 comments Download
M tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_event_details_table.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_event_sub_view.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_instant_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_object_sub_view.html View 1 chunk +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/multi_sample_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/multi_thread_slice_sub_view.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/single_cpu_slice_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_instant_event_sub_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/analysis/single_object_instance_sub_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html View 1 2 2 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html View 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/analysis/stacked_pane_view.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/analysis/stacked_pane_view_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/annotations/comment_box_annotation_view.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/checkbox_picker_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/color_legend.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/container_that_decorates_its_children.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/container_that_decorates_its_children_test.html View 6 chunks +9 lines, -9 lines 0 comments Download
M tracing/tracing/ui/base/deep_utils_test.html View 2 chunks +5 lines, -5 lines 0 comments Download
M tracing/tracing/ui/base/dom_helpers.html View 6 chunks +10 lines, -9 lines 0 comments Download
M tracing/tracing/ui/base/drag_handle_test.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/dropdown_test.html View 1 chunk +12 lines, -7 lines 0 comments Download
M tracing/tracing/ui/base/hotkey_controller_test.html View 3 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/ui/base/info_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/info_bar_group.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/list_and_associated_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/mouse_mode_selector.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/overlay.html View 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/overlay_test.html View 5 chunks +10 lines, -10 lines 0 comments Download
M tracing/tracing/ui/base/radio_picker_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/base/resize_sensor_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/tab_view_test.html View 10 chunks +26 lines, -26 lines 0 comments Download
M tracing/tracing/ui/base/table.html View 5 chunks +8 lines, -7 lines 0 comments Download
M tracing/tracing/ui/base/table_header_cell.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/base/toolbar_button_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/brushing_state_controller_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/about_tracing.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/about_tracing/profiling_view.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_controller.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html View 1 4 chunks +13 lines, -11 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/display_item_debugger.html View 1 3 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_picker.html View 1 6 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_tree_quad_stack_view.html View 1 11 chunks +13 lines, -13 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/layer_view.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_debugger.html View 1 3 chunks +6 lines, -6 lines 0 comments Download
M tracing/tracing/ui/extras/chrome/cc/picture_ops_list_view.html View 1 3 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/extras/drive/index.html View 3 chunks +7 lines, -7 lines 0 comments Download
M tracing/tracing/ui/extras/side_panel/alerts_side_panel.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html View 3 chunks +8 lines, -8 lines 0 comments Download
M tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html View 5 chunks +9 lines, -8 lines 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_instance_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/extras/system_stats/system_stats_snapshot_view.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/find_controller_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/metrics_debugger_app.html View 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/side_panel/side_panel_container.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/timeline_track_view.html View 1 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/timeline_view.html View 7 chunks +9 lines, -8 lines 0 comments Download
M tracing/tracing/ui/timeline_view_test.html View 2 chunks +3 lines, -3 lines 0 comments Download
M tracing/tracing/ui/timeline_viewport.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/alert_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/async_slice_group_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/chart_series_test.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/chart_track_test.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/counter_track_perf_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/counter_track_test.html View 2 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/cpu_track_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/device_track.html View 1 1 chunk +2 lines, -1 line 0 comments Download
M tracing/tracing/ui/tracks/device_track_test.html View 4 chunks +4 lines, -4 lines 0 comments Download
M tracing/tracing/ui/tracks/drawing_container_perf_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/frame_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/global_memory_dump_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/interaction_track_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/letter_dot_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/object_instance_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/power_series_track_test.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/process_memory_dump_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/process_track_base.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/ui/tracks/rect_track_test.html View 6 chunks +15 lines, -14 lines 0 comments Download
M tracing/tracing/ui/tracks/ruler_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/slice_group_track_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/ui/tracks/thread_track_test.html View 1 chunk +4 lines, -3 lines 0 comments Download
M tracing/tracing/ui/view_specific_brushing_state_test.html View 1 chunk +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/ui/histogram_span.html View 1 chunk +1 line, -1 line 0 comments Download
M tracing/tracing/value/ui/scalar_span_test.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923953003/1
4 years, 7 months ago (2016-04-27 18:19:46 UTC) #4
commit-bot: I haz the power
Failed to apply patch for tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html: While running git apply --index -3 -p1; error: patch ...
4 years, 7 months ago (2016-04-27 18:20:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1923953003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1923953003/20001
4 years, 7 months ago (2016-04-27 18:22:51 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-04-27 18:23:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698