tracing/tracing/ui/timeline_viewport.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/timeline_viewport.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tracing/tracing/ui/timeline_viewport.html

diff --git a/tracing/tracing/ui/timeline_viewport.html b/tracing/tracing/ui/timeline_viewport.html

index 61b4e3c3ec0242ad7d2f8e96fb4e1f79abd2f381..1230fd6511edb9227599c49dfba8f6fb013072ad 100644

--- a/tracing/tracing/ui/timeline_viewport.html

+++ b/tracing/tracing/ui/timeline_viewport.html

@@ -120,7 +120,7 @@ tr.exportTo('tr.ui', function() {

this.iframe_ = document.createElement('iframe');

this.iframe_.style.cssText =

'position:absolute;width:100%;height:0;border:0;visibility:hidden;';

- this.parentEl_.appendChild(this.iframe_);

+ Polymer.dom(this.parentEl_).appendChild(this.iframe_);

this.iframe_.contentWindow.addEventListener('resize', this.onResize_);

}

« no previous file with comments | « tracing/tracing/ui/timeline_view_test.html ('k') | tracing/tracing/ui/tracks/alert_track_test.html » ('j') | no next file with comments »