tracing/tracing/ui/tracks/process_track_base.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/tracks/process_track_base.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/tracks/process_memory_dump_track_test.html ('k') | tracing/tracing/ui/tracks/rect_track_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/tracks/process_track_base.html

diff --git a/tracing/tracing/ui/tracks/process_track_base.html b/tracing/tracing/ui/tracks/process_track_base.html

index 9cb442e2c79abd254a5ef11d273136c5f2cbdfa7..e386ef0c72c52f046e2f5336593a90d293aa4a4e 100644

--- a/tracing/tracing/ui/tracks/process_track_base.html

+++ b/tracing/tracing/ui/tracks/process_track_base.html

@@ -51,7 +51,7 @@ tr.exportTo('tr.ui.tracks', function() {

this.processNameEl_.classList.add('process-track-name');

this.headerEl_ = tr.ui.b.createDiv({className: 'process-track-header'});

- this.headerEl_.appendChild(this.processNameEl_);

+ Polymer.dom(this.headerEl_).appendChild(this.processNameEl_);

this.headerEl_.addEventListener('click', this.onHeaderClick_.bind(this));

Polymer.dom(this).appendChild(this.headerEl_);

« no previous file with comments | « tracing/tracing/ui/tracks/process_memory_dump_track_test.html ('k') | tracing/tracing/ui/tracks/rect_track_test.html » ('j') | no next file with comments »