Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_header_pane.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_header_pane.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_header_pane.html b/tracing/tracing/ui/analysis/memory_dump_header_pane.html
index cf4af9eb589855c19c349dc84ebcfbdea0bbd1ff..ebe6fa315e4171d6561cdade9d501f2718f5352d 100644
--- a/tracing/tracing/ui/analysis/memory_dump_header_pane.html
+++ b/tracing/tracing/ui/analysis/memory_dump_header_pane.html
@@ -58,19 +58,19 @@ tr.exportTo('tr.ui.analysis', function() {
},
ready: function() {
- this.$.aggregation_mode_container.appendChild(tr.ui.b.createSelector(
- this, 'aggregationMode', 'memoryDumpHeaderPane.aggregationMode',
- tr.ui.analysis.MemoryColumn.AggregationMode.DIFF,
- [
- {
- label: 'Diff',
- value: tr.ui.analysis.MemoryColumn.AggregationMode.DIFF
- },
- {
- label: 'Max',
- value: tr.ui.analysis.MemoryColumn.AggregationMode.MAX
- }
- ]));
+ Polymer.dom(this.$.aggregation_mode_container).appendChild(
+ tr.ui.b.createSelector(this, 'aggregationMode',
+ 'memoryDumpHeaderPane.aggregationMode',
+ tr.ui.analysis.MemoryColumn.AggregationMode.DIFF, [
+ {
+ label: 'Diff',
+ value: tr.ui.analysis.MemoryColumn.AggregationMode.DIFF
+ },
+ {
+ label: 'Max',
+ value: tr.ui.analysis.MemoryColumn.AggregationMode.MAX
+ }
+ ]));
},
/**
@@ -124,19 +124,20 @@ tr.exportTo('tr.ui.analysis', function() {
var containerDumpCount = this.containerMemoryDumps_.length;
var isMultiSelection = containerDumpCount > 1;
- this.$.label.appendChild(document.createTextNode(
+ Polymer.dom(this.$.label).appendChild(document.createTextNode(
'Selected ' + containerDumpCount + ' memory dump' +
(isMultiSelection ? 's' : '') +
' in ' + this.containerMemoryDumps_[0].containerName + ' at '));
// TODO(petrcermak): Use <tr-v-ui-scalar-span> once it can be displayed
// inline. See https://github.com/catapult-project/catapult/issues/1371.
- this.$.label.appendChild(document.createTextNode(
+ Polymer.dom(this.$.label).appendChild(document.createTextNode(
tr.v.Unit.byName.timeStampInMs.format(
this.containerMemoryDumps_[0].start)));
if (isMultiSelection) {
var ELLIPSIS = String.fromCharCode(8230);
- this.$.label.appendChild(document.createTextNode(ELLIPSIS));
- this.$.label.appendChild(document.createTextNode(
+ Polymer.dom(this.$.label).appendChild(
+ document.createTextNode(ELLIPSIS));
+ Polymer.dom(this.$.label).appendChild(document.createTextNode(
tr.v.Unit.byName.timeStampInMs.format(
this.containerMemoryDumps_[containerDumpCount - 1].start)));
}
« no previous file with comments | « tracing/tracing/ui/analysis/generic_object_view.html ('k') | tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698