tracing/tracing/ui/analysis/multi_event_sub_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/multi_event_sub_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/multi_event_details_table.html ('k') | tracing/tracing/ui/analysis/multi_instant_event_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/multi_event_sub_view.html

diff --git a/tracing/tracing/ui/analysis/multi_event_sub_view.html b/tracing/tracing/ui/analysis/multi_event_sub_view.html

index 05362976d10b8a0c279a2dccc3287533e35934b4..9fbf712c5791f7bd5779da108f4d9a76b30ca2a0 100644

--- a/tracing/tracing/ui/analysis/multi_event_sub_view.html

+++ b/tracing/tracing/ui/analysis/multi_event_sub_view.html

@@ -111,12 +111,12 @@ Polymer({

eventsHaveDuration: this.eventsHaveDuration_,

eventsHaveSubRows: this.eventsHaveSubRows_

});

- this.$.content.appendChild(summaryTableEl);

+ Polymer.dom(this.$.content).appendChild(summaryTableEl);

var selectionSummaryTableEl = document.createElement(

'tr-ui-a-selection-summary-table');

selectionSummaryTableEl.selection = this.currentSelection_;

- this.$.content.appendChild(selectionSummaryTableEl);

+ Polymer.dom(this.$.content).appendChild(selectionSummaryTableEl);

if (numTitles === 1) {

var detailsTableEl = document.createElement(

@@ -124,7 +124,7 @@ Polymer({

detailsTableEl.eventsHaveDuration = this.eventsHaveDuration_;

detailsTableEl.eventsHaveSubRows = this.eventsHaveSubRows_;

detailsTableEl.selection = selection;

- this.$.content.appendChild(detailsTableEl);

+ Polymer.dom(this.$.content).appendChild(detailsTableEl);

}

});