Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: tracing/tracing/ui/base/overlay_test.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/overlay.html ('k') | tracing/tracing/ui/base/radio_picker_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/overlay_test.html
diff --git a/tracing/tracing/ui/base/overlay_test.html b/tracing/tracing/ui/base/overlay_test.html
index d1d1b31e8e3c19b3ae3b6acab5a9e81d3a8fc467..74151bc4614575a8f1a8090b3be6c1536a656110 100644
--- a/tracing/tracing/ui/base/overlay_test.html
+++ b/tracing/tracing/ui/base/overlay_test.html
@@ -40,9 +40,9 @@ tr.b.unittest.testSuite(function() {
dlg.classList.add('example-overlay');
dlg.title = 'ExampleOverlay';
dlg.innerHTML = 'hello';
- dlg.buttons.appendChild(makeButton('i am a button'));
- dlg.buttons.appendChild(makeCloseButton(dlg));
- dlg.buttons.appendChild(tr.ui.b.createSpan(
+ Polymer.dom(dlg.buttons).appendChild(makeButton('i am a button'));
+ Polymer.dom(dlg.buttons).appendChild(makeCloseButton(dlg));
+ Polymer.dom(dlg.buttons).appendChild(tr.ui.b.createSpan(
{textContent: 'i am a span'}));
addShowButtonForDialog.call(this, dlg);
});
@@ -61,7 +61,7 @@ tr.b.unittest.testSuite(function() {
dlg.userCanClose = false;
dlg.title = 'Unclosable';
dlg.innerHTML = 'This has no close X button.';
- dlg.buttons.appendChild(makeCloseButton(dlg));
+ Polymer.dom(dlg.buttons).appendChild(makeCloseButton(dlg));
addShowButtonForDialog.call(this, dlg);
});
@@ -70,16 +70,16 @@ tr.b.unittest.testSuite(function() {
dlg.title = 'TallContent';
var contentEl = document.createElement('div');
contentEl.style.overflowY = 'auto';
- dlg.appendChild(contentEl);
+ Polymer.dom(dlg).appendChild(contentEl);
for (var i = 0; i < 1000; i++) {
var el = document.createElement('div');
el.textContent = 'line ' + i;
- contentEl.appendChild(el);
+ Polymer.dom(contentEl).appendChild(el);
}
- dlg.buttons.appendChild(makeButton('i am a button'));
+ Polymer.dom(dlg.buttons).appendChild(makeButton('i am a button'));
addShowButtonForDialog.call(this, dlg);
});
@@ -90,10 +90,10 @@ tr.b.unittest.testSuite(function() {
var el = document.createElement('div');
el.style.webkitFlex = '1 0 auto';
el.textContent = 'line ' + i;
- dlg.appendChild(el);
+ Polymer.dom(dlg).appendChild(el);
}
- dlg.buttons.appendChild(makeButton('i am a button'));
+ Polymer.dom(dlg.buttons).appendChild(makeButton('i am a button'));
addShowButtonForDialog.call(this, dlg);
});
@@ -101,7 +101,7 @@ tr.b.unittest.testSuite(function() {
var dlg = new tr.ui.b.Overlay();
dlg.title = 'Test closeclick event';
var closeBtn = makeCloseButton(dlg);
- dlg.buttons.appendChild(closeBtn);
+ Polymer.dom(dlg.buttons).appendChild(closeBtn);
var closeClicked = false;
dlg.addEventListener('closeclick', function() {
« no previous file with comments | « tracing/tracing/ui/base/overlay.html ('k') | tracing/tracing/ui/base/radio_picker_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698