Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: tracing/tracing/ui/timeline_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/timeline_track_view.html ('k') | tracing/tracing/ui/timeline_view_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/timeline_view.html
diff --git a/tracing/tracing/ui/timeline_view.html b/tracing/tracing/ui/timeline_view.html
index d8b236c4c5837228bb620020b491b1382c8d91f5..7aeb069d55f3ced54a789b7ec458449dfad48239 100644
--- a/tracing/tracing/ui/timeline_view.html
+++ b/tracing/tracing/ui/timeline_view.html
@@ -173,7 +173,7 @@ Polymer({
window.tr.metrics.sh.SystemHealthMetric) {
this.railScoreSpan_ = document.createElement(
'tr-metrics-ui-sh-system-health-span');
- this.rightControls.appendChild(this.railScoreSpan_);
+ Polymer.dom(this.rightControls).appendChild(this.railScoreSpan_);
} else {
this.railScoreSpan_ = undefined;
}
@@ -182,7 +182,7 @@ Polymer({
this.optionsDropdown_.iconElement.textContent = 'View Options';
this.showFlowEvents_ = false;
- this.optionsDropdown_.appendChild(tr.ui.b.createCheckBox(
+ Polymer.dom(this.optionsDropdown_).appendChild(tr.ui.b.createCheckBox(
this, 'showFlowEvents',
'tr.ui.TimelineView.showFlowEvents', false,
'Flow events'));
@@ -191,13 +191,14 @@ Polymer({
this, 'highlightVSync',
'tr.ui.TimelineView.highlightVSync', false,
'Highlight VSync');
- this.optionsDropdown_.appendChild(this.highlightVSyncCheckbox_);
+ Polymer.dom(this.optionsDropdown_).appendChild(
+ this.highlightVSyncCheckbox_);
this.initMetadataButton_();
this.initConsoleButton_();
this.initHelpButton_();
- this.collapsingControls.appendChild(this.scriptingCtl_);
+ Polymer.dom(this.collapsingControls).appendChild(this.scriptingCtl_);
this.dragEl_ = this.$.drag_handle;
@@ -249,7 +250,7 @@ Polymer({
if (!link) {
link = document.createElement('link');
link.rel = 'shortcut icon';
- document.head.appendChild(link);
+ Polymer.dom(document.head).appendChild(link);
}
link.href = faviconData;
},
@@ -282,7 +283,7 @@ Polymer({
function onClick(e) {
var dlg = new tr.ui.b.Overlay();
dlg.title = 'Chrome Tracing Help';
- dlg.appendChild(
+ Polymer.dom(dlg).appendChild(
document.createElement('tr-ui-timeline-view-help-overlay'));
dlg.visible = true;
@@ -314,7 +315,7 @@ Polymer({
'tr-ui-timeline-view-metadata-overlay');
metadataOverlay.metadata = this.model.metadata;
- dlg.appendChild(metadataOverlay);
+ Polymer.dom(dlg).appendChild(metadataOverlay);
dlg.visible = true;
e.stopPropagation();
@@ -393,7 +394,7 @@ Polymer({
this.trackView.brushingStateController = this.brushingStateController_;
- this.trackViewContainer_.appendChild(this.trackView_);
+ Polymer.dom(this.trackViewContainer_).appendChild(this.trackView_);
this.trackView_.viewport.addEventListener(
'change', this.onViewportChanged_);
}
« no previous file with comments | « tracing/tracing/ui/timeline_track_view.html ('k') | tracing/tracing/ui/timeline_view_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698