Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Unified Diff: tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
diff --git a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
index 44ad59d857e39c4558601daada334c6abd04738f..12db37eee0855fa757e869f2ba1c8874ad9fd6db 100644
--- a/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
+++ b/tracing/tracing/ui/extras/about_tracing/record_selection_dialog.html
@@ -241,11 +241,11 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
'click',
this.onRecordButtonClicked_.bind(this));
this.recordButtonEl_.style.fontSize = '110%';
- this.buttons.appendChild(this.recordButtonEl_);
+ Polymer.dom(this.buttons).appendChild(this.recordButtonEl_);
this.categoriesView_ = this.querySelector('.categories-column-view');
this.presetsEl_ = this.querySelector('.category-presets');
- this.presetsEl_.appendChild(tr.ui.b.createOptionGroup(
+ Polymer.dom(this.presetsEl_).appendChild(tr.ui.b.createOptionGroup(
this, 'currentlyChosenPreset',
'about_tracing.record_selection_dialog_preset',
DEFAULT_PRESETS[0].categoryFilter,
@@ -267,10 +267,12 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
'recordSelectionDialog.useSampling', DEFAULT_SAMPLING_TRACING,
'State sampling');
this.tracingModesContainerEl_ = this.querySelector('.tracing-modes');
- this.tracingModesContainerEl_.appendChild(this.tracingRecordModeSltr_);
- this.tracingModesContainerEl_.appendChild(this.systemTracingBn_);
- this.tracingModesContainerEl_.appendChild(this.samplingTracingBn_);
-
+ Polymer.dom(this.tracingModesContainerEl_).appendChild(
+ this.tracingRecordModeSltr_);
+ Polymer.dom(this.tracingModesContainerEl_).appendChild(
+ this.systemTracingBn_);
+ Polymer.dom(this.tracingModesContainerEl_).appendChild(
+ this.samplingTracingBn_);
this.enabledCategoriesContainerEl_ =
this.querySelector('.default-enabled-categories .categories');
@@ -539,10 +541,10 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
labelEl.setAttribute('for', category);
var divEl = document.createElement('div');
- divEl.appendChild(inputEl);
- divEl.appendChild(labelEl);
+ Polymer.dom(divEl).appendChild(inputEl);
+ Polymer.dom(divEl).appendChild(labelEl);
- parent.appendChild(divEl);
+ Polymer.dom(parent).appendChild(divEl);
}
},
@@ -648,10 +650,10 @@ tr.exportTo('tr.ui.e.about_tracing', function() {
for (var i = 0; i < messages.length; ++i) {
var messageDiv = document.createElement('div');
messageDiv.textContent = messages[i];
- contentDiv.appendChild(messageDiv);
+ Polymer.dom(contentDiv).appendChild(messageDiv);
}
this.warningOverlay_.textContent = '';
- this.warningOverlay_.appendChild(contentDiv);
+ Polymer.dom(this.warningOverlay_).appendChild(contentDiv);
},
createDefaultDisabledWarningDialog_: function(warningLink) {

Powered by Google App Engine
This is Rietveld 408576698