tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/memory_dump_sub_view_util.html ('k') | tracing/tracing/ui/analysis/multi_event_details_table.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

index 4e31694d93643e79c65bde7d75fd8d81683734cb..69585627461d7ce1c45b4b57a7858a231ee7cbc9 100644

--- a/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

+++ b/tracing/tracing/ui/analysis/memory_dump_sub_view_util_test.html

@@ -53,7 +53,7 @@ tr.b.unittest.testSuite(function() {

var node = tr.ui.b.asHTMLOrTextNode(value);

var spanEl = document.createElement('span');

- spanEl.appendChild(node);

+ Polymer.dom(spanEl).appendChild(node);

test.addHTMLOutput(spanEl);

assert.strictEqual(node.textContent, expectedTextContent);