tracing/tracing/ui/analysis/single_object_instance_sub_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/single_object_instance_sub_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_instant_event_sub_view.html ('k') | tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/single_object_instance_sub_view.html

diff --git a/tracing/tracing/ui/analysis/single_object_instance_sub_view.html b/tracing/tracing/ui/analysis/single_object_instance_sub_view.html

index 976edb3dc4679a8f913735ff676e7165167a3ece..44c361c72409217b47e2f980af72f439a353e1a4 100644

--- a/tracing/tracing/ui/analysis/single_object_instance_sub_view.html

+++ b/tracing/tracing/ui/analysis/single_object_instance_sub_view.html

@@ -84,7 +84,7 @@ Polymer({

instance.category, instance.typeName);

if (typeInfo) {

var customView = new typeInfo.constructor();

- this.$.content.appendChild(customView);

+ Polymer.dom(this.$.content).appendChild(customView);

customView.modelEvent = instance;

} else {

this.appendGenericAnalysis_(instance);

@@ -113,7 +113,7 @@ Polymer({

instance.snapshots.forEach(function(snapshot) {

var snapshotLink = document.createElement('tr-ui-a-analysis-link');

snapshotLink.selection = new tr.model.EventSet(snapshot);

- snapshotsEl.appendChild(snapshotLink);

+ Polymer.dom(snapshotsEl).appendChild(snapshotLink);

});

}

});