Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tracing/tracing/ui/analysis/memory_dump_sub_view_util.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/analysis/memory_dump_sub_view_util.html
diff --git a/tracing/tracing/ui/analysis/memory_dump_sub_view_util.html b/tracing/tracing/ui/analysis/memory_dump_sub_view_util.html
index 3220735b53d05305661704cc26c6939d5dc54718..d6dd7626ea1894cfe87fc54e641adf2a6facc2be 100644
--- a/tracing/tracing/ui/analysis/memory_dump_sub_view_util.html
+++ b/tracing/tracing/ui/analysis/memory_dump_sub_view_util.html
@@ -102,12 +102,14 @@ tr.exportTo('tr.ui.analysis', function() {
var prefixEl = tr.ui.b.createSpan({textContent: prefix});
// Enforce same width of '+++' and '---'.
prefixEl.style.fontFamily = 'monospace';
- titleEl.appendChild(prefixEl);
- titleEl.appendChild(tr.ui.b.asHTMLOrTextNode(NO_BREAK_SPACE));
+ Polymer.dom(titleEl).appendChild(prefixEl);
+ Polymer.dom(titleEl).appendChild(
+ tr.ui.b.asHTMLOrTextNode(NO_BREAK_SPACE));
}
if (color !== undefined)
titleEl.style.color = color;
- titleEl.appendChild(tr.ui.b.asHTMLOrTextNode(formattedTitle));
+ Polymer.dom(titleEl).appendChild(
+ tr.ui.b.asHTMLOrTextNode(formattedTitle));
return titleEl;
},
@@ -329,7 +331,8 @@ tr.exportTo('tr.ui.analysis', function() {
var fieldEl = document.createElement('span');
fieldEl.style.display = 'flex';
fieldEl.style.alignItems = 'center';
- fieldEl.appendChild(tr.ui.b.asHTMLOrTextNode(formattedFields));
+ Polymer.dom(fieldEl).appendChild(
+ tr.ui.b.asHTMLOrTextNode(formattedFields));
// Add info icons with tooltips.
infos.forEach(function(info) {
@@ -341,7 +344,7 @@ tr.exportTo('tr.ui.analysis', function() {
if (info.color !== undefined)
infoEl.style.color = info.color;
infoEl.title = info.message;
- fieldEl.appendChild(infoEl);
+ Polymer.dom(fieldEl).appendChild(infoEl);
}, this);
// Set the color of the element.
@@ -565,15 +568,15 @@ tr.exportTo('tr.ui.analysis', function() {
if (firstString === undefined) {
// String was added ("+NEW_VALUE" in red).
var spanEl = tr.ui.b.createSpan({color: 'red'});
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode('+'));
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode(
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode('+'));
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode(
this.formatSingleField(lastString)));
return spanEl;
} else if (lastString === undefined) {
// String was removed ("-OLD_VALUE" in green).
var spanEl = tr.ui.b.createSpan({color: 'green'});
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode('-'));
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode(
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode('-'));
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode(
this.formatSingleField(firstString)));
return spanEl;
} else if (firstString === lastString) {
@@ -582,11 +585,11 @@ tr.exportTo('tr.ui.analysis', function() {
} else {
// String changed ("OLD_VALUE -> NEW_VALUE" in orange).
var spanEl = tr.ui.b.createSpan({color: 'DarkOrange'});
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode(
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode(
this.formatSingleField(firstString)));
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode(
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode(
' ' + RIGHTWARDS_ARROW + ' '));
- spanEl.appendChild(tr.ui.b.asHTMLOrTextNode(
+ Polymer.dom(spanEl).appendChild(tr.ui.b.asHTMLOrTextNode(
this.formatSingleField(lastString)));
return spanEl;
}

Powered by Google App Engine
This is Rietveld 408576698