tracing/tracing/ui/analysis/multi_object_sub_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/multi_object_sub_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/multi_instant_event_sub_view.html ('k') | tracing/tracing/ui/analysis/multi_sample_sub_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/multi_object_sub_view.html

diff --git a/tracing/tracing/ui/analysis/multi_object_sub_view.html b/tracing/tracing/ui/analysis/multi_object_sub_view.html

index 52668e37f4d4df52621b0c6af5a9546eacddeac3..f7c562e1c70ad082642a13b1894a17be50665227 100644

--- a/tracing/tracing/ui/analysis/multi_object_sub_view.html

+++ b/tracing/tracing/ui/analysis/multi_object_sub_view.html

@@ -62,15 +62,15 @@ Polymer({

return tr.v.ui.createScalarSpan(event.ts, timeSpanConfig);

var spanEl = document.createElement('span');

- spanEl.appendChild(tr.v.ui.createScalarSpan(

+ Polymer.dom(spanEl).appendChild(tr.v.ui.createScalarSpan(

event.creationTs, timeSpanConfig));

- spanEl.appendChild(tr.ui.b.createSpan({

+ Polymer.dom(spanEl).appendChild(tr.ui.b.createSpan({

textContent: '-',

marginLeft: '4px',

marginRight: '4px'

}));

if (event.deletionTs != Number.MAX_VALUE) {

- spanEl.appendChild(tr.v.ui.createScalarSpan(

+ Polymer.dom(spanEl).appendChild(tr.v.ui.createScalarSpan(

event.deletionTs, timeSpanConfig));

}

return spanEl;