tracing/tracing/ui/analysis/generic_object_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/generic_object_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/frame_power_usage_chart.html ('k') | tracing/tracing/ui/analysis/memory_dump_header_pane.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/generic_object_view.html

diff --git a/tracing/tracing/ui/analysis/generic_object_view.html b/tracing/tracing/ui/analysis/generic_object_view.html

index 9c791119b4043f89894084603cca77c2387944a0..77f16432d7b3d2dda270713e8b2f72525551ee4c 100644

--- a/tracing/tracing/ui/analysis/generic_object_view.html

+++ b/tracing/tracing/ui/analysis/generic_object_view.html

@@ -248,19 +248,19 @@ Polymer({

indentSpan.style.whiteSpace = 'pre';

for (var i = 0; i < indent; i++)

indentSpan.textContent += ' ';

- row.appendChild(indentSpan);

+ Polymer.dom(row).appendChild(indentSpan);

var labelSpan = document.createElement('span');

labelSpan.textContent = label;

- row.appendChild(labelSpan);

+ Polymer.dom(row).appendChild(labelSpan);

- row.appendChild(dataElement);

+ Polymer.dom(row).appendChild(dataElement);

var suffixSpan = document.createElement('span');

suffixSpan.textContent = suffix;

- row.appendChild(suffixSpan);

+ Polymer.dom(row).appendChild(suffixSpan);

row.dataElement = dataElement;

- this.$.content.appendChild(row);

+ Polymer.dom(this.$.content).appendChild(row);

appendSimpleText_: function(label, indent, text, suffix) {

@@ -291,8 +291,8 @@ Polymer({

this.labelEl_ = document.createElement('div');

this.genericObjectView_ =

document.createElement('tr-ui-a-generic-object-view');

- this.shadowRoot.appendChild(this.labelEl_);

- this.shadowRoot.appendChild(this.genericObjectView_);

+ Polymer.dom(this.shadowRoot).appendChild(this.labelEl_);

+ Polymer.dom(this.shadowRoot).appendChild(this.genericObjectView_);

get label() {