Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: tracing/tracing/ui/base/dom_helpers.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/base/deep_utils_test.html ('k') | tracing/tracing/ui/base/drag_handle_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/ui/base/dom_helpers.html
diff --git a/tracing/tracing/ui/base/dom_helpers.html b/tracing/tracing/ui/base/dom_helpers.html
index acdcb2fa0ac83968104f2659afabc003e2882d98..8841c9b9448bfcdf3d69313d26e537083eba9c2e 100644
--- a/tracing/tracing/ui/base/dom_helpers.html
+++ b/tracing/tracing/ui/base/dom_helpers.html
@@ -33,7 +33,7 @@ tr.exportTo('tr.ui.b', function() {
if (opt_dictionary.tooltip)
spanEl.title = opt_dictionary.tooltip;
if (opt_dictionary.parent)
- opt_dictionary.parent.appendChild(spanEl);
+ Polymer.dom(opt_dictionary.parent).appendChild(spanEl);
if (opt_dictionary.bold)
spanEl.style.fontWeight = 'bold';
if (opt_dictionary.italic)
@@ -56,7 +56,7 @@ tr.exportTo('tr.ui.b', function() {
if (opt_dictionary.className)
divEl.className = opt_dictionary.className;
if (opt_dictionary.parent)
- opt_dictionary.parent.appendChild(divEl);
+ Polymer.dom(opt_dictionary.parent).appendChild(divEl);
if (opt_dictionary.textContent)
divEl.textContent = opt_dictionary.textContent;
if (opt_dictionary.maxWidth)
@@ -101,7 +101,7 @@ tr.exportTo('tr.ui.b', function() {
optionEl.textContent = item.label;
optionEl.targetPropertyValue = item.value;
optionEl.item = item;
- selectorEl.appendChild(optionEl);
+ Polymer.dom(selectorEl).appendChild(optionEl);
}
function onChange(e) {
var value = selectorEl.selectedOptions[0].targetPropertyValue;
@@ -194,8 +194,8 @@ tr.exportTo('tr.ui.b', function() {
labelEl.setAttribute('for', id);
var spanEl = createSpan({className: 'labeled-option'});
- spanEl.appendChild(radioEl);
- spanEl.appendChild(labelEl);
+ Polymer.dom(spanEl).appendChild(radioEl);
+ Polymer.dom(spanEl).appendChild(labelEl);
spanEl.__defineSetter__('checked', function(opt_bool) {
var changed = radioEl.checked !== (!!opt_bool);
@@ -209,9 +209,10 @@ tr.exportTo('tr.ui.b', function() {
return radioEl.checked;
});
- optionGroupEl.appendChild(spanEl);
+ Polymer.dom(optionGroupEl).appendChild(spanEl);
}
- optionGroupEl.appendChild(createEditCategorySpan(optionGroupEl, targetEl));
+ Polymer.dom(optionGroupEl).appendChild(
+ createEditCategorySpan(optionGroupEl, targetEl));
// Since this option group element is not yet added to the tree,
// querySelector will fail during updateEditCategoriesStatus_ call.
// Hence, creating the element with the 'expanded' classlist category
@@ -253,8 +254,8 @@ tr.exportTo('tr.ui.b', function() {
var labelEl = document.createElement('label');
labelEl.textContent = label;
labelEl.setAttribute('for', id);
- spanEl.appendChild(buttonEl);
- spanEl.appendChild(labelEl);
+ Polymer.dom(spanEl).appendChild(buttonEl);
+ Polymer.dom(spanEl).appendChild(labelEl);
spanEl.__defineSetter__('checked', function(opt_bool) {
var changed = buttonEl.checked !== (!!opt_bool);
« no previous file with comments | « tracing/tracing/ui/base/deep_utils_test.html ('k') | tracing/tracing/ui/base/drag_handle_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698