tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/extras/side_panel/alerts_side_panel.html ('k') | tracing/tracing/ui/extras/side_panel/time_summary_side_panel.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

diff --git a/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html b/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

index 63117718955982440b17cfbb94f1b95a6736ece1..c6734b3d83551c19fd25db86f9e2a71dc2bd21e8 100644

--- a/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

+++ b/tracing/tracing/ui/extras/side_panel/input_latency_side_panel.html

@@ -178,7 +178,7 @@ Polymer({

this.selectedProcessId_ = labels[0].value;

var toolbarEl = this.$.toolbar;

- toolbarEl.appendChild(tr.ui.b.createSelector(

+ Polymer.dom(toolbarEl).appendChild(tr.ui.b.createSelector(

this, 'frametimeType',

'inputLatencySidePanel.frametimeType', this.frametimeType_,

[{label: 'Main Thread Frame Times',

@@ -186,7 +186,7 @@ Polymer({

{label: 'Impl Thread Frame Times',

value: tr.model.helpers.IMPL_FRAMETIME_TYPE}

]));

- toolbarEl.appendChild(tr.ui.b.createSelector(

+ Polymer.dom(toolbarEl).appendChild(tr.ui.b.createSelector(

this, 'selectedProcessId',

'inputLatencySidePanel.selectedProcessId',

this.selectedProcessId_,

@@ -259,29 +259,29 @@ Polymer({

// Create summary.

var latencySummaryText = document.createElement('div');

- latencySummaryText.appendChild(tr.ui.b.createSpan({

+ laPolymer.dom(tencySummaryText).appendChild(tr.ui.b.createSpan({

textContent: 'Average Latency ' + averageLatency + ' ms',

bold: true}));

- resultArea.appendChild(latencySummaryText);

+ Polymer.dom(resultArea).appendChild(latencySummaryText);

var frametimeSummaryText = document.createElement('div');

- frametimeSummaryText.appendChild(tr.ui.b.createSpan({

+ Polymer.dom(frametimeSummaryText).appendChild(tr.ui.b.createSpan({

textContent: 'Average Frame Time ' + averageFrametime + ' ms',

bold: true}));

- resultArea.appendChild(frametimeSummaryText);

+ Polymer.dom(resultArea).appendChild(frametimeSummaryText);

if (latencyData.length !== 0) {

this.latencyChart_ = this.createLatencyLineChart(

latencyData, 'Latency Over Time');

this.registerMouseEventForLatencyChart_();

- resultArea.appendChild(this.latencyChart_);

+ Polymer.dom(resultArea).appendChild(this.latencyChart_);

}

if (frametimeData.length != 0) {

this.frametimeChart_ = this.createLatencyLineChart(

frametimeData, 'Frame Times');

this.frametimeChart_.style.display = 'block';

- resultArea.appendChild(this.frametimeChart_);

+ Polymer.dom(resultArea).appendChild(this.frametimeChart_);

}