tracing/tracing/ui/analysis/stacked_pane_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/stacked_pane_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html ('k') | tracing/tracing/ui/analysis/stacked_pane_view_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/stacked_pane_view.html

diff --git a/tracing/tracing/ui/analysis/stacked_pane_view.html b/tracing/tracing/ui/analysis/stacked_pane_view.html

index 2705a01cecb3c8a06c6dabfcbb31d11a39315c64..dc00028ec3daa7e66a715703bac7d9a93cabb2c1 100644

--- a/tracing/tracing/ui/analysis/stacked_pane_view.html

+++ b/tracing/tracing/ui/analysis/stacked_pane_view.html

@@ -37,7 +37,7 @@ Sample use case:

Create an empty stacked pane view and add it to the DOM:

var paneView = document.createElement('tr-ui-a-stacked-pane-view');

- someParentView.appendChild(paneView);

+ Polymer.dom(someParentView).appendChild(paneView);

Define one or more pane subclasses:

@@ -160,7 +160,7 @@ Polymer({

this.listeners_.set(pane, listener);

pane.addEventListener('request-child-pane-change', listener);

- paneContainer.appendChild(pane);

+ Polymer.dom(paneContainer).appendChild(pane);

pane.appended();