tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/memory_dump_heap_details_pane.html ('k') | tracing/tracing/ui/analysis/memory_dump_sub_view_util.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

diff --git a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

index bb377bba241540850ceebd370557e5303020112e..ffd2a98fd5fbed347af1afeab0942d0f3d654b36 100644

--- a/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

+++ b/tracing/tracing/ui/analysis/memory_dump_overview_pane_test.html

@@ -373,7 +373,7 @@ tr.b.unittest.testSuite(function() {

tr.ui.analysis.createTestPane('tr-ui-a-memory-dump-overview-pane');

var table = viewEl.$.table;

containerEl.textContent = '';

- containerEl.appendChild(viewEl);

+ Polymer.dom(containerEl).appendChild(viewEl);

var displayedProcessMemoryDumps = processMemoryDumps.map(

function(memoryDumps) {