tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html - Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html

Issue 1923953003: [polymer] Switches .appendChild() to Polymer.dom()...appendChild() (Closed) Base URL: git@github.com:catapult-project/catapult.git@polymer10-migration

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tracing/tracing/ui/analysis/single_object_snapshot_sub_view.html ('k') | tracing/tracing/ui/analysis/stacked_pane_view.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html

diff --git a/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html b/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html

index 78c25bfa694d0399b631162682c95295fe1fa697..bbf9b07dad3b632ab64cb6c27a746361ef3228d8 100644

--- a/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html

+++ b/tracing/tracing/ui/analysis/single_thread_time_slice_sub_view.html

@@ -141,7 +141,7 @@ Polymer({

timeSlice.getAssociatedCpuSlice());

cpuLink.textContent =

timeSlice.cpuOnWhichThreadWasRunning.userFriendlyName;

- onCpuEl.appendChild(cpuLink);

+ Polymer.dom(onCpuEl).appendChild(cpuLink);

} else {

onCpuEl.parentElement.removeChild(onCpuEl);

@@ -153,7 +153,7 @@ Polymer({

cpuLink.textContent = cpuSliceThatTookCpu.thread.userFriendlyName;

else

cpuLink.textContent = cpuSliceThatTookCpu.title;

- runningInsteadEl.appendChild(cpuLink);

+ Polymer.dom(runningInsteadEl).appendChild(cpuLink);

} else {

runningInsteadEl.parentElement.removeChild(runningInsteadEl);

}

@@ -167,7 +167,7 @@ Polymer({

argsEl.parentElement.style.display = '';

argsEl.textContent = '';

- argsEl.appendChild(argsView);

+ aPolymer.dom(rgsEl).appendChild(argsView);

} else {

argsEl.parentElement.style.display = 'none';

}