Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium… (Closed)

Created:
4 years, 9 months ago by reed1
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium.org/1789633002/ )" This reverts commit 9283d20afc27571f7a871d1bd1100dd5df584941. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1793303002 Committed: https://skia.googlesource.com/skia/+/1a9b9640843a64af8d9d90337ec3b3fea663196a

Patch Set 1 #

Patch Set 2 : make pictureRef a value, so its clearer what's going on #

Unified diffs Side-by-side diffs Delta from patch set Stats (+531 lines, -733 lines) Patch
M gm/gradientDirtyLaundry.cpp View 2 chunks +10 lines, -16 lines 0 comments Download
M gm/gradient_matrix.cpp View 2 chunks +8 lines, -11 lines 0 comments Download
M gm/gradients.cpp View 19 chunks +75 lines, -97 lines 0 comments Download
M gm/gradients_2pt_conical.cpp View 2 chunks +81 lines, -100 lines 0 comments Download
M gm/gradients_no_texture.cpp View 3 chunks +14 lines, -17 lines 0 comments Download
M gm/gradtext.cpp View 4 chunks +12 lines, -15 lines 0 comments Download
M gm/hairmodes.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefilterstransformed.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M gm/imagefromyuvtextures.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/imagetoyuvplanes.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M gm/lcdblendmodes.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M gm/lumafilter.cpp View 4 chunks +9 lines, -16 lines 0 comments Download
M gm/matrixconvolution.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gm/modecolorfilters.cpp View 6 chunks +13 lines, -18 lines 0 comments Download
M gm/ovals.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M gm/patch.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M gm/perspshaders.cpp View 3 chunks +9 lines, -12 lines 0 comments Download
M gm/pictureimagegenerator.cpp View 2 chunks +4 lines, -8 lines 0 comments Download
M gm/pictureshader.cpp View 3 chunks +12 lines, -15 lines 0 comments Download
M gm/pictureshadertile.cpp View 1 3 chunks +8 lines, -10 lines 0 comments Download
M gm/rectangletexture.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M gm/rects.cpp View 1 chunk +3 lines, -7 lines 0 comments Download
M gm/roundrects.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M gm/samplerstress.cpp View 3 chunks +6 lines, -11 lines 0 comments Download
M gm/shaderbounds.cpp View 4 chunks +18 lines, -18 lines 0 comments Download
M gm/shadertext.cpp View 5 chunks +15 lines, -15 lines 0 comments Download
M gm/shadertext2.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M gm/shadertext3.cpp View 2 chunks +6 lines, -10 lines 0 comments Download
M gm/shadows.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M gm/shallowgradient.cpp View 2 chunks +12 lines, -16 lines 0 comments Download
M gm/skbug_257.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M gm/srcmode.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/surface.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M gm/tablecolorfilter.cpp View 4 chunks +9 lines, -9 lines 0 comments Download
M gm/textbloblooper.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M gm/textblobshader.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M gm/texturedomaineffect.cpp View 1 chunk +12 lines, -12 lines 0 comments Download
M gm/tiledscaledbitmap.cpp View 3 chunks +3 lines, -6 lines 0 comments Download
M gm/tilemodes.cpp View 4 chunks +11 lines, -13 lines 0 comments Download
M gm/tilemodes_scaled.cpp View 4 chunks +11 lines, -12 lines 0 comments Download
M gm/tinybitmap.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M gm/transparency.cpp View 2 chunks +7 lines, -12 lines 0 comments Download
M gm/vertices.cpp View 4 chunks +14 lines, -15 lines 0 comments Download
M gm/verylargebitmap.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M gm/xfermodes.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M gm/xfermodes2.cpp View 4 chunks +9 lines, -13 lines 0 comments Download
M gm/xfermodes3.cpp View 3 chunks +13 lines, -18 lines 0 comments Download
M tests/BitmapHeapTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/BlitRowTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M tests/GradientTest.cpp View 11 chunks +25 lines, -47 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M tests/PaintImageFilterTest.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M tests/PictureShaderTest.cpp View 2 chunks +5 lines, -7 lines 0 comments Download
M tests/PictureTest.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M tests/RecorderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/ShaderOpacityTest.cpp View 2 chunks +10 lines, -22 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793303002/20001
4 years, 9 months ago (2016-03-13 21:05:17 UTC) #3
fmalita_google_do_not_use
lgtm
4 years, 9 months ago (2016-03-13 21:12:14 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1793303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1793303002/20001
4 years, 9 months ago (2016-03-13 21:12:46 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-13 21:14:03 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1a9b9640843a64af8d9d90337ec3b3fea663196a

Powered by Google App Engine
This is Rietveld 408576698