gm/imagefromyuvtextures.cpp - Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/imagefromyuvtextures.cpp

Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: make pictureRef a value, so its clearer what's going on Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/imagefromyuvtextures.cpp

diff --git a/gm/imagefromyuvtextures.cpp b/gm/imagefromyuvtextures.cpp

index c53df295cd0c6ba843347de382fbea49758524b2..6280ae740b98442c8100098e0da1772d2625f00d 100644

--- a/gm/imagefromyuvtextures.cpp

+++ b/gm/imagefromyuvtextures.cpp

@@ -40,9 +40,9 @@ protected:

SkPaint paint;

static const SkColor kColors[] =

{ SK_ColorBLUE, SK_ColorYELLOW, SK_ColorGREEN, SK_ColorWHITE };

- paint.setShader(SkGradientShader::CreateRadial(SkPoint::Make(0,0), kBmpSize / 2.f, kColors,

- nullptr, SK_ARRAY_COUNT(kColors),

- SkShader::kMirror_TileMode))->unref();

+ paint.setShader(SkGradientShader::MakeRadial(SkPoint::Make(0,0), kBmpSize / 2.f, kColors,

+ nullptr, SK_ARRAY_COUNT(kColors),

+ SkShader::kMirror_TileMode));

SkBitmap rgbBmp;

rgbBmp.allocN32Pixels(kBmpSize, kBmpSize, true);

SkCanvas canvas(rgbBmp);

« no previous file with comments | « gm/imagefilterstransformed.cpp ('k') | gm/imagetoyuvplanes.cpp » ('j') | no next file with comments »