tests/PaintImageFilterTest.cpp - Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/PaintImageFilterTest.cpp

Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: make pictureRef a value, so its clearer what's going on Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/PaintImageFilterTest.cpp

diff --git a/tests/PaintImageFilterTest.cpp b/tests/PaintImageFilterTest.cpp

index b71fe471196f88b9604730b582cf53a191e80542..f1c0c2eb9739bd563273e15da4c0c4ff19f60a5a 100644

--- a/tests/PaintImageFilterTest.cpp

+++ b/tests/PaintImageFilterTest.cpp

@@ -30,10 +30,9 @@ static void test_unscaled(skiatest::Reporter* reporter) {

SkScalar pos[] = {0, SK_ScalarHalf, SK_Scalar1};

SkScalar radius = SkIntToScalar(5);

- SkAutoTUnref<SkShader> s(SkGradientShader::CreateRadial(

- center, radius, colors, pos, SK_ARRAY_COUNT(colors), SkShader::kClamp_TileMode));

SkPaint gradientPaint;

- gradientPaint.setShader(s);

+ gradientPaint.setShader(SkGradientShader::MakeRadial(

+ center, radius, colors, pos, SK_ARRAY_COUNT(colors), SkShader::kClamp_TileMode));

// Test using the image filter

{

@@ -77,10 +76,9 @@ static void test_scaled(skiatest::Reporter* reporter) {