gm/xfermodes.cpp - Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/xfermodes.cpp

Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: make pictureRef a value, so its clearer what's going on Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/xfermodes.cpp

diff --git a/gm/xfermodes.cpp b/gm/xfermodes.cpp

index 1a71255d3e0b94ca06e9e18ef278391a9bd2ef1c..a1427cf212e4a92b78d962c8898b06558ab8b2bd 100644

--- a/gm/xfermodes.cpp

+++ b/gm/xfermodes.cpp

@@ -261,10 +261,8 @@ protected:

const SkScalar h = SkIntToScalar(H);

SkMatrix m;

m.setScale(SkIntToScalar(6), SkIntToScalar(6));

- SkShader* s = SkShader::CreateBitmapShader(fBG,

- SkShader::kRepeat_TileMode,

- &m);

+ auto s = SkShader::MakeBitmapShader(fBG, SkShader::kRepeat_TileMode,

+ SkShader::kRepeat_TileMode, &m);

SkPaint labelP;

labelP.setAntiAlias(true);

@@ -325,7 +323,6 @@ protected:

y0 = 0;

}

- s->unref();

}

private:

« no previous file with comments | « gm/verylargebitmap.cpp ('k') | gm/xfermodes2.cpp » ('j') | no next file with comments »