tests/RecorderTest.cpp - Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecorderTest.cpp

Issue 1793303002: Reland of "more shader-->sp conversions (patchset #5 id:80001 of https://codereview.chromium… (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: make pictureRef a value, so its clearer what's going on Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/RecorderTest.cpp

diff --git a/tests/RecorderTest.cpp b/tests/RecorderTest.cpp

index b4bc58dddde0333d8c081d4fc71bdb5dc026fb74..9d7fda5483d5b026b4bd0aaa3d7a5f8fd0da3cc7 100644

--- a/tests/RecorderTest.cpp

+++ b/tests/RecorderTest.cpp

@@ -58,7 +58,7 @@ DEF_TEST(Recorder_RefLeaking, r) {

SkRect bounds = SkRect::MakeWH(320, 240);

SkPaint paint;

- paint.setShader(SkShader::CreateEmptyShader())->unref();

+ paint.setShader(SkShader::MakeEmptyShader());

REPORTER_ASSERT(r, paint.getShader()->unique());

{

« no previous file with comments | « tests/PictureTest.cpp ('k') | tests/ShaderOpacityTest.cpp » ('j') | no next file with comments »