DevTools: generate string16-based handlers for v8_inspector.

DevTools: generate string16-based handlers for v8_inspector.

BUG=580337
Committed: https://crrev.com/06595f0c4376466cfdd21d2c7f6fc91d9c1142a6
Cr-Commit-Position: refs/heads/master@{#379933}

[pfeldman, 2016-03-08 00:35:51]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-03-08 00:44:41]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-08 00:45:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767883002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767883002/60001

[commit-bot: I haz the power, 2016-03-08 01:11:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 01:11:59]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[dgozman, 2016-03-08 01:35:12]

lgtm

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp (right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorCSSAgent.cpp:1111:
*errorString = String("Style sheet with id " + styleSheetId + " not found");
template consturctor

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:145: if
domain in ["Runtime", "Debugger", "Profiler", "HeapProfiler"]:
Mark them in protocol.json.

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Maybe.h (right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Maybe.h:9: #include
"platform/inspector_protocol/String16.h"
class String16;

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/Values.cpp (right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Values.cpp:39: void
appendUnsignedAsHex(unsigned number, String16Builder* dst)
UChar number

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:54:
String name = injectedScript->origin().latin1();
String16

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:56:
return reinterpret_cast<const char *>(name.characters8());
Is characters8 null-terminated?

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:60:
protocol::Vector<String> m_strings;
String16

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp
(right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp:9:
static String16 coreString(v8::Local<v8::String> v8String)
rename method

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp (right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:635:
m_client->sendProtocolMessage(sessionId, callId,
String(message->toJSONString()), stateToSend);
operator WebString

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:697:
m_client->sendProtocolMessage(m_notificationQueue[i].first, 0,
String(m_notificationQueue[i].second->toJSONString()), WebString());
ditto

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp:739: if
(!protocol::Dispatcher::getCommandName(String(message), &commandName))
ditto

[pfeldman, 2016-03-08 02:24:59]

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py
(right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py:145: if
domain in ["Runtime", "Debugger", "Profiler", "HeapProfiler"]:
On 2016/03/08 01:35:12, dgozman wrote:
> Mark them in protocol.json.

We'll split them.

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp
(right):

https://codereview.chromium.org/1767883002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/V8HeapProfilerAgentImpl.cpp:56:
return reinterpret_cast<const char *>(name.characters8());
YES!

[pfeldman, 2016-03-08 02:26:02]

All done!

[pfeldman, 2016-03-08 04:47:40]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-08 04:47:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1767883002/#ps120001
(title: "for landing")

[commit-bot: I haz the power, 2016-03-08 04:47:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767883002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767883002/120001

[commit-bot: I haz the power, 2016-03-08 05:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 05:10:31]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pfeldman, 2016-03-08 06:16:18]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-08 06:16:19]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1767883002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-03-08 06:16:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767883002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767883002/140001

[commit-bot: I haz the power, 2016-03-08 06:51:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 06:51:02]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[pfeldman, 2016-03-08 16:39:37]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-08 16:39:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1767883002/#ps120002
(title: " ")

[commit-bot: I haz the power, 2016-03-08 16:39:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767883002/120002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767883002/120002

[commit-bot: I haz the power, 2016-03-08 17:29:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-08 17:29:15]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-03-08 19:18:13]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-03-08 19:18:14]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1767883002/#ps170001
(title: "for landing 2")

[commit-bot: I haz the power, 2016-03-08 19:18:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1767883002/170001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1767883002/170001

[commit-bot: I haz the power, 2016-03-08 22:16:16]

Committed patchset #10 (id:170001)

[commit-bot: I haz the power, 2016-03-08 22:18:32]

Description was changed from

==========
DevTools: generate string16-based handlers for v8_inspector.

BUG=580337
==========

to

==========
DevTools: generate string16-based handlers for v8_inspector.

BUG=580337

Committed: https://crrev.com/06595f0c4376466cfdd21d2c7f6fc91d9c1142a6
Cr-Commit-Position: refs/heads/master@{#379933}
==========

[commit-bot: I haz the power, 2016-03-08 22:18:34]

Patchset 10 (id:??) landed as
https://crrev.com/06595f0c4376466cfdd21d2c7f6fc91d9c1142a6
Cr-Commit-Position: refs/heads/master@{#379933}