third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

index eb5dec1c9376e8e8eb17fff67eb39816ceea843a..593de177119c2c69ce8ca1bcb7a52ee5385ebc53 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h

@@ -47,8 +47,6 @@ namespace blink {

class V8HeapProfilerAgent;

class V8RuntimeAgent;

-typedef String ErrorString;

class CORE_EXPORT InspectorHeapProfilerAgent final : public InspectorBaseAgent<InspectorHeapProfilerAgent, protocol::Frontend::HeapProfiler>, public protocol::Dispatcher::HeapProfilerCommandHandler {

WTF_MAKE_NONCOPYABLE(InspectorHeapProfilerAgent);

USING_FAST_MALLOC_WILL_BE_REMOVED(InspectorHeapProfilerAgent);

@@ -68,9 +66,9 @@ public:

void stopTrackingHeapObjects(ErrorString*, const Maybe<bool>& reportProgress) override;

void takeHeapSnapshot(ErrorString*, const Maybe<bool>& reportProgress) override;

void collectGarbage(ErrorString*) override;

- void getObjectByHeapObjectId(ErrorString*, const String& objectId, const Maybe<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

- void addInspectedHeapObject(ErrorString*, const String& heapObjectId) override;

- void getHeapObjectId(ErrorString*, const String& objectId, String* heapSnapshotObjectId) override;

+ void getObjectByHeapObjectId(ErrorString*, const String16& objectId, const Maybe<String16>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result) override;

+ void addInspectedHeapObject(ErrorString*, const String16& heapObjectId) override;

+ void getHeapObjectId(ErrorString*, const String16& objectId, String16* heapSnapshotObjectId) override;

void startSampling(ErrorString*) override;

void stopSampling(ErrorString*, OwnPtr<protocol::HeapProfiler::SamplingHeapProfile>*) override;