third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8Debugger.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h

index c05ab714ac25ae67c2400c1cc35894d53f825fe5..15eaca8372814bb3fc39382286ebffa87dcdd8eb 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8DebuggerAgent.h

@@ -21,11 +21,11 @@ public:

virtual ~V8DebuggerAgent() { }

// API for the embedder to report native activities.

- virtual void schedulePauseOnNextStatement(const String& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

+ virtual void schedulePauseOnNextStatement(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

virtual void cancelPauseOnNextStatement() = 0;

virtual bool canBreakProgram() = 0;

- virtual void breakProgram(const String& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

- virtual void breakProgramOnException(const String& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

+ virtual void breakProgram(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

+ virtual void breakProgramOnException(const String16& breakReason, PassOwnPtr<protocol::DictionaryValue> data) = 0;

virtual void willExecuteScript(int scriptId) = 0;

virtual void didExecuteScript() = 0;

virtual void reset() = 0;

@@ -36,7 +36,7 @@ public:

// Async call stacks implementation

static const int unknownAsyncOperationId;

- virtual int traceAsyncOperationStarting(const String& description) = 0;

+ virtual int traceAsyncOperationStarting(const String16& description) = 0;

virtual void traceAsyncCallbackStarting(int operationId) = 0;

virtual void traceAsyncCallbackCompleted() = 0;

virtual void traceAsyncOperationCompleted(int operationId) = 0;