third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorStyleSheet.h ('k') | third_party/WebKit/Source/core/inspector/InspectorWorkerAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

index 5db02b66eaf7e2bdde8f5a70be738455ba20d20d..14d95947e79f051c467a224fc70679dafe16fde7 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorTracingAgent.cpp

@@ -66,7 +66,7 @@ void InspectorTracingAgent::end(ErrorString* errorString, PassOwnPtr<EndCallback

String InspectorTracingAgent::sessionId()

{

- String result;

+ String16 result;

if (m_state)

m_state->getString(TracingAgentState::sessionId, &result);

return result;

@@ -94,7 +94,7 @@ void InspectorTracingAgent::disable(ErrorString*)

void InspectorTracingAgent::resetSessionId()

{

m_state->remove(TracingAgentState::sessionId);

- m_workerAgent->setTracingSessionId(sessionId());

+ m_workerAgent->setTracingSessionId(String());

}

} // namespace blink