Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(849)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
index b52a7a1f6430b695fc392b92f45644dd42d0ddbe..b30ca47f76b3dafdaf9828e26c3726a6fb6719b2 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.h
@@ -31,8 +31,9 @@
#ifndef JavaScriptCallFrame_h
#define JavaScriptCallFrame_h
+#include "platform/inspector_protocol/String16.h"
+#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
-#include "wtf/text/WTFString.h"
#include <v8.h>
namespace blink {
@@ -52,8 +53,8 @@ public:
int sourceID() const;
int line() const;
int column() const;
- String scriptName() const;
- String functionName() const;
+ String16 scriptName() const;
+ String16 functionName() const;
int functionLine() const;
int functionColumn() const;
@@ -63,7 +64,7 @@ public:
v8::Local<v8::Value> scopeStartLocation(int scopeIndex) const;
v8::Local<v8::Value> scopeEndLocation(int scopeIndex) const;
v8::Local<v8::Value> thisObject() const;
- String stepInPositions() const;
+ String16 stepInPositions() const;
bool isAtReturn() const;
v8::Local<v8::Value> returnValue() const;
@@ -83,7 +84,7 @@ private:
JavaScriptCallFrame(V8DebuggerClient*, v8::Local<v8::Context> debuggerContext, v8::Local<v8::Object> callFrame);
int callV8FunctionReturnInt(const char* name) const;
- String callV8FunctionReturnString(const char* name) const;
+ String16 callV8FunctionReturnString(const char* name) const;
v8::Local<v8::Value> callScopeLocationFunction(const char* name, int scopeIndex) const;
V8DebuggerClient* m_client;

Powered by Google App Engine
This is Rietveld 408576698