third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorResourceAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

index fefd9367f087b861ecbe638b2ca04690351915db..b221302d3fff4fd03ddc04d2ccf82f0e637ef079 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp

@@ -86,13 +86,13 @@ void InspectorProfilerAgent::restore()

}

// Protocol implementation.

-void InspectorProfilerAgent::consoleProfile(ExecutionContext* context, const String& title)

+void InspectorProfilerAgent::consoleProfile(ExecutionContext* context, const String16& title)

{

UseCounter::count(context, UseCounter::DevToolsConsoleProfile);

m_v8ProfilerAgent->consoleProfile(title);

}

-void InspectorProfilerAgent::consoleProfileEnd(const String& title)

+void InspectorProfilerAgent::consoleProfileEnd(const String16& title)

{

m_v8ProfilerAgent->consoleProfileEnd(title);

}

@@ -119,7 +119,7 @@ void InspectorProfilerAgent::setSamplingInterval(ErrorString* error, int interva

void InspectorProfilerAgent::start(ErrorString* error)

{

m_v8ProfilerAgent->start(error);

- if (m_client && !*error)

+ if (m_client && error->isEmpty())

m_client->profilingStarted();

}