Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1428)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
index 3a9f3f07ef8e050a69d974bd8fd7baaba65faa88..2cde7f119801498f1f0de0391381a17d6c546f42 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_h.template
@@ -14,7 +14,6 @@ namespace protocol {
class FrontendChannel;
class DispatcherImplWeakPtr;
-using ErrorString = String;
class PLATFORM_EXPORT Dispatcher {
public:
@@ -102,15 +101,13 @@ public:
LastEntry,
};
- void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String& errorMessage) const;
- virtual void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String& errorMessage, ErrorSupport*) const = 0;
- virtual void dispatch(int sessionId, const String& message) = 0;
- static bool getCommandName(const String& message, String* result);
+ void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String16& errorMessage) const;
+ virtual void reportProtocolError(int sessionId, int callId, CommonErrorCode, const String16& errorMessage, ErrorSupport*) const = 0;
+ virtual void dispatch(int sessionId, const String16& message) = 0;
+ static bool getCommandName(const String16& message, String16* result);
};
} // namespace protocol
} // namespace blink
-using blink::protocol::ErrorString;
-
#endif // !defined({{class_name}}_h)

Powered by Google App Engine
This is Rietveld 408576698