third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.h ('k') | third_party/WebKit/Source/core/inspector/InspectorInputAgent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

index ffc6972dc5598d118e45e3292dd508464a73a414..5b61f07c93ceff26be57e184832764afa96c0edf 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorHeapProfilerAgent.cpp

@@ -164,7 +164,7 @@ void InspectorHeapProfilerAgent::takeHeapSnapshot(ErrorString* errorString, cons

m_v8HeapProfilerAgent->takeHeapSnapshot(errorString, reportProgress);

}

-void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, const String& heapSnapshotObjectId, const protocol::Maybe<String>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result)

+void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, const String16& heapSnapshotObjectId, const protocol::Maybe<String16>& objectGroup, OwnPtr<protocol::Runtime::RemoteObject>* result)

{

bool ok;

unsigned id = heapSnapshotObjectId.toUInt(&ok);

@@ -181,7 +181,7 @@ void InspectorHeapProfilerAgent::getObjectByHeapObjectId(ErrorString* error, con

m_v8HeapProfilerAgent->getObjectByHeapObjectId(error, heapSnapshotObjectId, objectGroup, result);

}

-void InspectorHeapProfilerAgent::addInspectedHeapObject(ErrorString* error, const String& inspectedHeapObjectId)

+void InspectorHeapProfilerAgent::addInspectedHeapObject(ErrorString* error, const String16& inspectedHeapObjectId)

{

bool ok;

unsigned id = inspectedHeapObjectId.toUInt(&ok);

@@ -198,7 +198,7 @@ void InspectorHeapProfilerAgent::addInspectedHeapObject(ErrorString* error, cons

m_v8HeapProfilerAgent->addInspectedHeapObject(error, inspectedHeapObjectId);

}

-void InspectorHeapProfilerAgent::getHeapObjectId(ErrorString* errorString, const String& objectId, String* heapSnapshotObjectId)

+void InspectorHeapProfilerAgent::getHeapObjectId(ErrorString* errorString, const String16& objectId, String16* heapSnapshotObjectId)

{

m_v8HeapProfilerAgent->getHeapObjectId(errorString, objectId, heapSnapshotObjectId);

}