third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h

index 905776f08dd776b1da4d840c4e282d1adf72a2c7..47c815a6c75f78e76e77b4b53edd8c2d496d5cc7 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorProfilerAgent.h

@@ -44,8 +44,6 @@ class InspectorFrontend;

class V8Debugger;

class V8ProfilerAgent;

-typedef String ErrorString;

class CORE_EXPORT InspectorProfilerAgent final : public InspectorBaseAgent<InspectorProfilerAgent, protocol::Frontend::Profiler>, public protocol::Dispatcher::ProfilerCommandHandler {

WTF_MAKE_NONCOPYABLE(InspectorProfilerAgent);

USING_FAST_MALLOC_WILL_BE_REMOVED(InspectorProfilerAgent);

@@ -67,8 +65,8 @@ public:

void clearFrontend() override;

void restore() override;

- void consoleProfile(ExecutionContext*, const String& title);

- void consoleProfileEnd(const String& title);

+ void consoleProfile(ExecutionContext*, const String16& title);

+ void consoleProfileEnd(const String16& title);

void enable(ErrorString*) override;

void disable(ErrorString*) override;