Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1291)

Unified Diff: third_party/WebKit/Source/platform/inspector_protocol/Array.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/inspector_protocol/Array.h
diff --git a/third_party/WebKit/Source/platform/inspector_protocol/Array.h b/third_party/WebKit/Source/platform/inspector_protocol/Array.h
index 4ab846611d50124e4cb60923703007a13fcddae2..087f848bdc025851dfbce8d0a6e54bb88811d217 100644
--- a/third_party/WebKit/Source/platform/inspector_protocol/Array.h
+++ b/third_party/WebKit/Source/platform/inspector_protocol/Array.h
@@ -8,9 +8,9 @@
#include "platform/PlatformExport.h"
#include "platform/inspector_protocol/Collections.h"
#include "platform/inspector_protocol/ErrorSupport.h"
+#include "platform/inspector_protocol/String16.h"
#include "platform/inspector_protocol/ValueConversions.h"
#include "platform/inspector_protocol/Values.h"
-#include "wtf/text/WTFString.h"
namespace blink {
namespace protocol {
@@ -33,7 +33,7 @@ public:
errors->push();
OwnPtr<Array<T>> result = adoptPtr(new Array<T>());
for (size_t i = 0; i < array->size(); ++i) {
- errors->setName("[" + String::number(i) + "]");
+ errors->setName("[" + String16::number(i) + "]");
T item = FromValue<T>::parse(array->at(i), errors);
result->m_vector.append(item);
}
@@ -71,6 +71,7 @@ private:
};
template<> class Array<String> : public ArrayBase<String> {};
+template<> class Array<String16> : public ArrayBase<String16> {};
template<> class Array<int> : public ArrayBase<int> {};
template<> class Array<double> : public ArrayBase<double> {};
template<> class Array<bool> : public ArrayBase<bool> {};
@@ -93,7 +94,7 @@ public:
OwnPtr<Array<T>> result = adoptPtr(new Array<T>());
errors->push();
for (size_t i = 0; i < array->size(); ++i) {
- errors->setName("[" + String::number(i) + "]");
+ errors->setName("[" + String16::number(i) + "]");
OwnPtr<T> item = FromValue<T>::parse(array->at(i), errors);
result->m_vector.append(item.release());
}

Powered by Google App Engine
This is Rietveld 408576698