Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: for landing 2 Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h
diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h
index 377d52d1851fe2f5a51f167abf1b6ce642545c5f..c085759908bdf156bc3136154eb1dd2a215bc525 100644
--- a/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h
+++ b/third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.h
@@ -7,8 +7,8 @@
#include "platform/inspector_protocol/Allocator.h"
#include "platform/inspector_protocol/Frontend.h"
+#include "platform/inspector_protocol/String16.h"
#include "platform/v8_inspector/public/V8ProfilerAgent.h"
-#include "wtf/text/WTFString.h"
namespace v8 {
class Isolate;
@@ -35,17 +35,17 @@ public:
void start(ErrorString*) override;
void stop(ErrorString*, OwnPtr<protocol::Profiler::CPUProfile>*) override;
- void consoleProfile(const String& title) override;
- void consoleProfileEnd(const String& title) override;
+ void consoleProfile(const String16& title) override;
+ void consoleProfileEnd(const String16& title) override;
void idleStarted() override;
void idleFinished() override;
private:
- String nextProfileId();
+ String16 nextProfileId();
- void startProfiling(const String& title);
- PassOwnPtr<protocol::Profiler::CPUProfile> stopProfiling(const String& title, bool serialize);
+ void startProfiling(const String16& title);
+ PassOwnPtr<protocol::Profiler::CPUProfile> stopProfiling(const String16& title, bool serialize);
bool isRecording() const;
@@ -57,7 +57,7 @@ private:
bool m_recordingCPUProfile;
class ProfileDescriptor;
protocol::Vector<ProfileDescriptor> m_startedProfiles;
- String m_frontendInitiatedProfileId;
+ String16 m_frontendInitiatedProfileId;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698