third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

index e63684b4698cde2e5cbbdea9e56fcefc335fbabe..c850159b2d98996a1903b055d27a22dfe74f9373 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptHost.h

@@ -31,9 +31,9 @@

#define InjectedScriptHost_h

#include "platform/inspector_protocol/Collections.h"

+#include "platform/inspector_protocol/String16.h"

#include "platform/v8_inspector/public/V8RuntimeAgent.h"

#include "wtf/PassOwnPtr.h"

-#include "wtf/text/WTFString.h"

#include <v8.h>

namespace blink {

@@ -69,10 +69,10 @@ public:

void inspectImpl(PassOwnPtr<protocol::Value> objectToInspect, PassOwnPtr<protocol::Value> hints);

void clearConsoleMessages();

- void debugFunction(const String& scriptId, int lineNumber, int columnNumber);

- void undebugFunction(const String& scriptId, int lineNumber, int columnNumber);

- void monitorFunction(const String& scriptId, int lineNumber, int columnNumber, const String& functionName);

- void unmonitorFunction(const String& scriptId, int lineNumber, int columnNumber);

+ void debugFunction(const String16& scriptId, int lineNumber, int columnNumber);

+ void undebugFunction(const String16& scriptId, int lineNumber, int columnNumber);

+ void monitorFunction(const String16& scriptId, int lineNumber, int columnNumber, const String16& functionName);

+ void unmonitorFunction(const String16& scriptId, int lineNumber, int columnNumber);

V8DebuggerImpl* debugger() { return m_debugger; }