third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8StackTraceImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

index d44eb78e6a062cf7e98c65ca36363ae1d092ed23..c1c506baae81406f104b1dafb3e1388d5f2d075c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8StringUtil.h

@@ -5,16 +5,16 @@

#ifndef V8StringUtil_h

#define V8StringUtil_h

-#include "wtf/text/WTFString.h"

+#include "platform/inspector_protocol/String16.h"

#include <v8.h>

namespace blink {

-v8::Local<v8::String> toV8String(v8::Isolate*, const String&);

-v8::Local<v8::String> toV8StringInternalized(v8::Isolate*, const String&);

+v8::Local<v8::String> toV8String(v8::Isolate*, const String16&);

+v8::Local<v8::String> toV8StringInternalized(v8::Isolate*, const String16&);

-String toWTFString(v8::Local<v8::String>);

-String toWTFStringWithTypeCheck(v8::Local<v8::Value>);

+String16 toProtocolString(v8::Local<v8::String>);

+String16 toProtocolStringWithTypeCheck(v8::Local<v8::Value>);

} // namespace blink