third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8DebuggerScript.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

index 7282921036a003f10929cb4113276f628d3cd292..a063620d5c32b531f92152a8bde89d3dfb3be242 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8FunctionCall.h

@@ -32,8 +32,8 @@

#define V8FunctionCall_h

#include "platform/inspector_protocol/Collections.h"

+#include "platform/inspector_protocol/String16.h"

-#include "wtf/text/WTFString.h"

#include <v8.h>

namespace blink {

@@ -42,10 +42,10 @@ class V8DebuggerClient;

class V8FunctionCall {

public:

- V8FunctionCall(V8DebuggerClient*, v8::Local<v8::Context>, v8::Local<v8::Value>, const String& name);

+ V8FunctionCall(V8DebuggerClient*, v8::Local<v8::Context>, v8::Local<v8::Value>, const String16& name);

void appendArgument(v8::Local<v8::Value>);

- void appendArgument(const String&);

+ void appendArgument(const String16&);

void appendArgument(int);

void appendArgument(bool);

void appendUndefinedArgument();