third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/public/V8RuntimeAgent.h ('k') | third_party/WebKit/Source/platform/v8_inspector/public/V8ToProtocolValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

index 2e00860b8fa65fcd1b672c7e4ed22289f55f8545..6d5d898c8e83de0a9a70044f13389507ecc36d11 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/public/V8StackTrace.h

@@ -26,15 +26,15 @@ public:

static const size_t maxCallStackSizeToCapture = 200;

virtual bool isEmpty() const = 0;

- virtual String topSourceURL() const = 0;

+ virtual String16 topSourceURL() const = 0;

virtual int topLineNumber() const = 0;

virtual int topColumnNumber() const = 0;

- virtual String topScriptId() const = 0;

- virtual String topFunctionName() const = 0;

+ virtual String16 topScriptId() const = 0;

+ virtual String16 topFunctionName() const = 0;

virtual ~V8StackTrace() { }

virtual PassOwnPtr<protocol::Runtime::StackTrace> buildInspectorObject() const = 0;

- virtual String toString() const = 0;

+ virtual String16 toString() const = 0;

};

} // namespace blink