third_party/WebKit/Source/platform/v8_inspector/V8Regex.h - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/V8Regex.h

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8ProfilerAgentImpl.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8Regex.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/V8Regex.h

diff --git a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.h b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.h

index 4bc885337096d46ec85a3e96d12a4f07ed3cb9c4..2c6c126cfa7d55be323e16d241f2f4f0c2d3b235 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/V8Regex.h

+++ b/third_party/WebKit/Source/platform/v8_inspector/V8Regex.h

@@ -6,7 +6,7 @@

#define V8Regex_h

#include "platform/inspector_protocol/Allocator.h"

-#include "wtf/text/WTFString.h"

+#include "platform/inspector_protocol/String16.h"

#include <v8.h>

namespace blink {

@@ -21,8 +21,8 @@ enum MultilineMode {

class V8Regex {

PROTOCOL_DISALLOW_COPY(V8Regex);

public:

- V8Regex(V8DebuggerImpl*, const String&, TextCaseSensitivity, MultilineMode = MultilineDisabled);

- int match(const String&, int startFrom = 0, int* matchLength = 0) const;

+ V8Regex(V8DebuggerImpl*, const String16&, bool caseSensitive, bool multiline = false);

+ int match(const String16&, int startFrom = 0, int* matchLength = 0) const;

bool isValid() const { return !m_regex.IsEmpty(); }

private: