third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/JavaScriptCallFrame.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp b/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

index 866e9146da3f55925669dfae72d02b9adb849009..96ad5879903b9c09a8f400cc8e771a3c7e859d20 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/PromiseTracker.cpp

@@ -4,6 +4,7 @@

#include "platform/v8_inspector/PromiseTracker.h"

+#include "platform/inspector_protocol/String16.h"

#include "platform/v8_inspector/V8DebuggerAgentImpl.h"

#include "platform/v8_inspector/V8StackTraceImpl.h"

#include "platform/v8_inspector/public/V8DebuggerClient.h"

@@ -108,9 +109,9 @@ void PromiseTracker::didReceiveV8PromiseEvent(v8::Local<v8::Context> context, v8

bool isNewPromise = false;

int id = promiseId(promise, &isNewPromise);

- String eventType = isNewPromise ? Debugger::PromiseUpdated::EventTypeEnum::New : Debugger::PromiseUpdated::EventTypeEnum::Update;

+ blink::protocol::String16 eventType = isNewPromise ? Debugger::PromiseUpdated::EventTypeEnum::New : Debugger::PromiseUpdated::EventTypeEnum::Update;

- String promiseStatus;

+ blink::protocol::String16 promiseStatus;

switch (status) {

case 0:

promiseStatus = Debugger::PromiseDetails::StatusEnum::Pending;