third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp - Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

Issue 1767883002: DevTools: generate string16-based handlers for v8_inspector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: for landing 2 Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.h ('k') | third_party/WebKit/Source/platform/v8_inspector/ScriptBreakpoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

diff --git a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

index 33258fae1b3064f07b17f56ee7a95831b12c3fa6..39d7787121b30ec01c223314e79c217cd2669e9c 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

+++ b/third_party/WebKit/Source/platform/v8_inspector/RemoteObjectId.cpp

@@ -12,7 +12,7 @@ namespace blink {

RemoteObjectIdBase::RemoteObjectIdBase() : m_injectedScriptId(0) { }

-PassOwnPtr<protocol::DictionaryValue> RemoteObjectIdBase::parseInjectedScriptId(const String& objectId)

+PassOwnPtr<protocol::DictionaryValue> RemoteObjectIdBase::parseInjectedScriptId(const String16& objectId)

{

OwnPtr<protocol::Value> parsedValue = protocol::parseJSON(objectId);

if (!parsedValue || parsedValue->type() != protocol::Value::TypeObject)

@@ -27,7 +27,7 @@ PassOwnPtr<protocol::DictionaryValue> RemoteObjectIdBase::parseInjectedScriptId(

RemoteObjectId::RemoteObjectId() : RemoteObjectIdBase(), m_id(0) { }

-PassOwnPtr<RemoteObjectId> RemoteObjectId::parse(const String& objectId)

+PassOwnPtr<RemoteObjectId> RemoteObjectId::parse(const String16& objectId)

{

OwnPtr<RemoteObjectId> result = adoptPtr(new RemoteObjectId());

OwnPtr<protocol::DictionaryValue> parsedObjectId = result->parseInjectedScriptId(objectId);

@@ -42,7 +42,7 @@ PassOwnPtr<RemoteObjectId> RemoteObjectId::parse(const String& objectId)

RemoteCallFrameId::RemoteCallFrameId() : RemoteObjectIdBase(), m_frameOrdinal(0) { }

-PassOwnPtr<RemoteCallFrameId> RemoteCallFrameId::parse(const String& objectId)

+PassOwnPtr<RemoteCallFrameId> RemoteCallFrameId::parse(const String16& objectId)

{

OwnPtr<RemoteCallFrameId> result = adoptPtr(new RemoteCallFrameId());

OwnPtr<protocol::DictionaryValue> parsedObjectId = result->parseInjectedScriptId(objectId);