Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 1544433002: Replace RE2 import with a dependency (Closed)

Created:
5 years ago by battre
Modified:
5 years ago
CC:
asanka, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, bruening+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, estade+watch_chromium.org, extensions-reviews_chromium.org, felt, gcasto+watchlist_chromium.org, glider+watch_chromium.org, jam, jdonnelly+autofillwatch_chromium.org, Jered, jfweitz+watch_chromium.org, jochen+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, mkwst+watchlist-passwords_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, piman+watch_chromium.org, rouslan+autofill_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace RE2 import with a dependency TBR=armansito@chromium.org,reillyg@chromium.org,piman@chromium.org BUG=568119 Committed: https://crrev.com/0739c642c9acce9e05ac8bb936a55fc6230a96f0 Cr-Commit-Position: refs/heads/master@{#366412}

Patch Set 1 #

Patch Set 2 : Fixed ChromeOS includes #

Patch Set 3 : Re-Added LICENSE and OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -47064 lines) Patch
M .gitignore View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/android/data_usage/data_use_matcher.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/hwid_checker.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/policy/system_log_uploader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_query.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/activity_log/activity_log.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/chrome_password_manager_client.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/local_files_ntp_source.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_loader_handler.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/content/renderer/password_form_conversion_utils.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/form_structure.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/dom_distiller/core/page_features.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/drive/drive_api_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/json_schema/json_schema_validator.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/keyed_service/core/dependency_graph_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/import/csv_reader.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/plugins/renderer/plugin_placeholder.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/schema.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/url_matcher/regex_set_matcher.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M components/url_matcher/url_matcher_factory.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/webcrypto/algorithms/test_helpers.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/shell/android/linker_test_apk/chromium_linker_test_linker_tests.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_device_enumerator_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M device/serial/serial_io_handler_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/web_request/form_data_parser.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/image_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/stack_frame.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/service/program_manager.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_control_list.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/leveldatabase/env_chromium.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
D third_party/re2/.gitignore View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/re2/AUTHORS View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/re2/BUILD View 1 2 1 chunk +0 lines, -121 lines 0 comments Download
M third_party/re2/BUILD.gn View 1 2 1 chunk +48 lines, -48 lines 0 comments Download
D third_party/re2/CMakeLists.txt View 1 2 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/re2/CONTRIBUTING.md View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/re2/CONTRIBUTORS View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/re2/Makefile View 1 2 1 chunk +0 lines, -310 lines 0 comments Download
D third_party/re2/README View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
D third_party/re2/WORKSPACE View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/re2/benchlog/benchlog.c2 View 1 2 1 chunk +0 lines, -2211 lines 0 comments Download
D third_party/re2/benchlog/benchlog.mini View 1 2 1 chunk +0 lines, -582 lines 0 comments Download
D third_party/re2/benchlog/benchlog.r70 View 1 2 1 chunk +0 lines, -1475 lines 0 comments Download
D third_party/re2/benchlog/benchlog.wreck View 1 2 1 chunk +0 lines, -1058 lines 0 comments Download
D third_party/re2/benchlog/benchplot.py View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/re2/benchlog/mktable View 1 2 1 chunk +0 lines, -155 lines 0 comments Download
D third_party/re2/doc/README.xkcd View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D third_party/re2/doc/mksyntaxgo View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/re2/doc/mksyntaxhtml View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/re2/doc/mksyntaxwiki View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
D third_party/re2/doc/syntax.html View 1 2 1 chunk +0 lines, -409 lines 0 comments Download
D third_party/re2/doc/syntax.txt View 1 2 1 chunk +0 lines, -399 lines 0 comments Download
D third_party/re2/doc/xkcd.png View 1 2 Binary file 0 comments Download
D third_party/re2/lib/git/commit-msg.hook View 1 2 1 chunk +0 lines, -104 lines 0 comments Download
D third_party/re2/libre2.symbols View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/re2/libre2.symbols.darwin View 1 2 1 chunk +0 lines, -19 lines 0 comments Download
M third_party/re2/re2.gyp View 1 2 2 chunks +49 lines, -49 lines 0 comments Download
D third_party/re2/re2.pc View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/re2/re2/bitstate.cc View 1 2 1 chunk +0 lines, -381 lines 0 comments Download
D third_party/re2/re2/compile.cc View 1 2 1 chunk +0 lines, -1151 lines 0 comments Download
D third_party/re2/re2/dfa.cc View 1 2 1 chunk +0 lines, -2112 lines 0 comments Download
D third_party/re2/re2/filtered_re2.h View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/re2/re2/filtered_re2.cc View 1 2 1 chunk +0 lines, -107 lines 0 comments Download
D third_party/re2/re2/make_perl_groups.pl View 1 2 1 chunk +0 lines, -116 lines 0 comments Download
D third_party/re2/re2/make_unicode_casefold.py View 1 2 1 chunk +0 lines, -147 lines 0 comments Download
D third_party/re2/re2/make_unicode_groups.py View 1 2 1 chunk +0 lines, -111 lines 0 comments Download
D third_party/re2/re2/mimics_pcre.cc View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/re2/re2/nfa.cc View 1 2 1 chunk +0 lines, -758 lines 0 comments Download
D third_party/re2/re2/onepass.cc View 1 2 1 chunk +0 lines, -611 lines 0 comments Download
D third_party/re2/re2/parse.cc View 1 2 1 chunk +0 lines, -2270 lines 0 comments Download
D third_party/re2/re2/perl_groups.cc View 1 2 1 chunk +0 lines, -119 lines 0 comments Download
D third_party/re2/re2/prefilter.h View 1 2 1 chunk +0 lines, -105 lines 0 comments Download
D third_party/re2/re2/prefilter.cc View 1 2 1 chunk +0 lines, -709 lines 0 comments Download
D third_party/re2/re2/prefilter_tree.h View 1 2 1 chunk +0 lines, -131 lines 0 comments Download
D third_party/re2/re2/prefilter_tree.cc View 1 2 1 chunk +0 lines, -402 lines 0 comments Download
D third_party/re2/re2/prog.h View 1 2 1 chunk +0 lines, -381 lines 0 comments Download
D third_party/re2/re2/prog.cc View 1 2 1 chunk +0 lines, -343 lines 0 comments Download
D third_party/re2/re2/re2.h View 1 2 1 chunk +0 lines, -882 lines 0 comments Download
D third_party/re2/re2/re2.cc View 1 2 1 chunk +0 lines, -1239 lines 0 comments Download
D third_party/re2/re2/regexp.h View 1 2 1 chunk +0 lines, -635 lines 0 comments Download
D third_party/re2/re2/regexp.cc View 1 2 1 chunk +0 lines, -938 lines 0 comments Download
D third_party/re2/re2/set.h View 1 2 1 chunk +0 lines, -55 lines 0 comments Download
D third_party/re2/re2/set.cc View 1 2 1 chunk +0 lines, -113 lines 0 comments Download
D third_party/re2/re2/simplify.cc View 1 2 1 chunk +0 lines, -652 lines 0 comments Download
D third_party/re2/re2/stringpiece.h View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/re2/re2/stringpiece.cc View 1 2 1 chunk +0 lines, -98 lines 0 comments Download
D third_party/re2/re2/testing/backtrack.cc View 1 2 1 chunk +0 lines, -255 lines 0 comments Download
D third_party/re2/re2/testing/charclass_test.cc View 1 2 1 chunk +0 lines, -223 lines 0 comments Download
D third_party/re2/re2/testing/compile_test.cc View 1 2 1 chunk +0 lines, -175 lines 0 comments Download
D third_party/re2/re2/testing/dfa_test.cc View 1 2 1 chunk +0 lines, -348 lines 0 comments Download
D third_party/re2/re2/testing/dump.cc View 1 2 1 chunk +0 lines, -166 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive1_test.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive2_test.cc View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive3_test.cc View 1 2 1 chunk +0 lines, -94 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive_test.cc View 1 2 1 chunk +0 lines, -38 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive_tester.h View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/re2/re2/testing/exhaustive_tester.cc View 1 2 1 chunk +0 lines, -188 lines 0 comments Download
D third_party/re2/re2/testing/filtered_re2_test.cc View 1 2 1 chunk +0 lines, -273 lines 0 comments Download
D third_party/re2/re2/testing/mimics_pcre_test.cc View 1 2 1 chunk +0 lines, -76 lines 0 comments Download
D third_party/re2/re2/testing/null_walker.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/re2/re2/testing/parse_test.cc View 1 2 1 chunk +0 lines, -470 lines 0 comments Download
D third_party/re2/re2/testing/possible_match_test.cc View 1 2 1 chunk +0 lines, -241 lines 0 comments Download
D third_party/re2/re2/testing/random_test.cc View 1 2 1 chunk +0 lines, -95 lines 0 comments Download
D third_party/re2/re2/testing/re2_arg_test.cc View 1 2 1 chunk +0 lines, -133 lines 0 comments Download
D third_party/re2/re2/testing/re2_test.cc View 1 2 1 chunk +0 lines, -1532 lines 0 comments Download
D third_party/re2/re2/testing/regexp_benchmark.cc View 1 2 1 chunk +0 lines, -1463 lines 0 comments Download
D third_party/re2/re2/testing/regexp_generator.h View 1 2 1 chunk +0 lines, -70 lines 0 comments Download
D third_party/re2/re2/testing/regexp_generator.cc View 1 2 1 chunk +0 lines, -264 lines 0 comments Download
D third_party/re2/re2/testing/regexp_test.cc View 1 2 1 chunk +0 lines, -82 lines 0 comments Download
D third_party/re2/re2/testing/required_prefix_test.cc View 1 2 1 chunk +0 lines, -67 lines 0 comments Download
D third_party/re2/re2/testing/search_test.cc View 1 2 1 chunk +0 lines, -325 lines 0 comments Download
D third_party/re2/re2/testing/set_test.cc View 1 2 1 chunk +0 lines, -140 lines 0 comments Download
D third_party/re2/re2/testing/simplify_test.cc View 1 2 1 chunk +0 lines, -260 lines 0 comments Download
D third_party/re2/re2/testing/string_generator.h View 1 2 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/re2/re2/testing/string_generator.cc View 1 2 1 chunk +0 lines, -112 lines 0 comments Download
D third_party/re2/re2/testing/string_generator_test.cc View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/re2/re2/testing/tester.h View 1 2 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/re2/re2/testing/tester.cc View 1 2 1 chunk +0 lines, -653 lines 0 comments Download
D third_party/re2/re2/tostring.cc View 1 2 1 chunk +0 lines, -345 lines 0 comments Download
D third_party/re2/re2/unicode.py View 1 2 1 chunk +0 lines, -297 lines 0 comments Download
D third_party/re2/re2/unicode_casefold.h View 1 2 1 chunk +0 lines, -75 lines 0 comments Download
D third_party/re2/re2/unicode_casefold.cc View 1 2 1 chunk +0 lines, -480 lines 0 comments Download
D third_party/re2/re2/unicode_groups.h View 1 2 1 chunk +0 lines, -64 lines 0 comments Download
D third_party/re2/re2/unicode_groups.cc View 1 2 1 chunk +0 lines, -5078 lines 0 comments Download
D third_party/re2/re2/variadic_function.h View 1 2 1 chunk +0 lines, -344 lines 0 comments Download
D third_party/re2/re2/walker-inl.h View 1 2 1 chunk +0 lines, -244 lines 0 comments Download
D third_party/re2/re2_test.bzl View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/re2/runtests View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/re2/testinstall.cc View 1 2 1 chunk +0 lines, -26 lines 0 comments Download
D third_party/re2/ucs2.diff View 1 2 1 chunk +0 lines, -567 lines 0 comments Download
D third_party/re2/util/atomicops.h View 1 2 1 chunk +0 lines, -179 lines 0 comments Download
D third_party/re2/util/benchmark.h View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/re2/util/benchmark.cc View 1 2 1 chunk +0 lines, -172 lines 0 comments Download
D third_party/re2/util/flags.h View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D third_party/re2/util/hash.cc View 1 2 1 chunk +0 lines, -231 lines 0 comments Download
D third_party/re2/util/logging.h View 1 2 1 chunk +0 lines, -109 lines 0 comments Download
D third_party/re2/util/logging.cc View 1 2 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/re2/util/mutex.h View 1 2 1 chunk +0 lines, -234 lines 0 comments Download
D third_party/re2/util/pcre.h View 1 2 1 chunk +0 lines, -666 lines 0 comments Download
D third_party/re2/util/pcre.cc View 1 2 1 chunk +0 lines, -999 lines 0 comments Download
D third_party/re2/util/random.h View 1 2 1 chunk +0 lines, -29 lines 0 comments Download
D third_party/re2/util/random.cc View 1 2 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/re2/util/rune.cc View 1 2 1 chunk +0 lines, -258 lines 0 comments Download
D third_party/re2/util/sparse_array.h View 1 2 1 chunk +0 lines, -465 lines 0 comments Download
D third_party/re2/util/sparse_set.h View 1 2 1 chunk +0 lines, -185 lines 0 comments Download
D third_party/re2/util/stringprintf.cc View 1 2 1 chunk +0 lines, -85 lines 0 comments Download
D third_party/re2/util/strutil.cc View 1 2 1 chunk +0 lines, -103 lines 0 comments Download
D third_party/re2/util/test.h View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/re2/util/test.cc View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/re2/util/thread.h View 1 2 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/re2/util/thread.cc View 1 2 1 chunk +0 lines, -42 lines 0 comments Download
D third_party/re2/util/threadwin.cc View 1 2 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/re2/util/utf.h View 1 2 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/re2/util/util.h View 1 2 1 chunk +0 lines, -149 lines 0 comments Download
D third_party/re2/util/valgrind.h View 1 2 1 chunk +0 lines, -4517 lines 0 comments Download
D third_party/re2/util/valgrind.cc View 1 2 1 chunk +0 lines, -20 lines 0 comments Download
M tools/ipc_fuzzer/message_tools/message_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
battre
Jochen, could you please do the global OWNERs sign off for all the stuff but ...
5 years ago (2015-12-21 10:44:37 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years ago (2015-12-21 12:40:48 UTC) #3
tfarina
Dominic, please do not delete the OWNERS file.
5 years ago (2015-12-21 15:55:53 UTC) #5
battre
On 2015/12/21 15:55:53, tfarina wrote: > Dominic, please do not delete the OWNERS file. Good ...
5 years ago (2015-12-21 16:13:18 UTC) #6
Nico
third_party/re2 lgtm
5 years ago (2015-12-21 17:00:35 UTC) #7
battre
TBR-ing for a trivial change in the #include path. armansito@chromium.org for device/ reillyg@chromium.org for extensions/ ...
5 years ago (2015-12-21 17:05:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1544433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1544433002/20001
5 years ago (2015-12-21 17:06:20 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:20001)
5 years ago (2015-12-21 17:45:35 UTC) #15
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/0739c642c9acce9e05ac8bb936a55fc6230a96f0 Cr-Commit-Position: refs/heads/master@{#366412}
5 years ago (2015-12-21 17:46:45 UTC) #17
tfarina
5 years ago (2015-12-21 17:54:04 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698