Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

At the moment the 3 modules that use extension API schemas, those in
extensions/common/api, chrome/common/extensions/api, and extensions/shell/api,
are generated with different C++ namespaces: "core_api", "api", and
"shell::api" respectively.

This is a pointless distinction to make since as far as JS is concerned they
must all go on the window.chrome object, therefore namespace conflicts are
impossible. It just ends up adding code noise.

The only problem it solves is that all bundle compiles are generated to the
same name, "GeneratedSchemas" and "GeneratedFunctionRegistry". This patch
solves that a different way, by adding a JSON schema compiler option to give
those generated classes a prefix such that they are "GeneratedSchemas",
"ChromeGeneratedSchemas", and "ShellGeneratedSchemas" respectively.
This lets us to a global substitution from "core_api" to just "api".

R=rockot@chromium.org, dpranke@chromium.org
TBR=ben@chromium.org

Committed: https://crrev.com/e58e6223146f09405229146fce6c1bfe6b71e4ce
Cr-Commit-Position: refs/heads/master@{#340119}

[not at google - send to devlin, 2015-07-16 22:08:32]

Hey Ken, I haven't quite finished this patch, but sending out now to get some
early feedback.

Does this look like the right thing to you? Seeing "core_api" everywhere was
annoying me.

See that 1 comment for an example for how the code will change, apart from mass
rename from core_api --> api.

(It doesn't quite compile yet, but I need to head off)

https://codereview.chromium.org/1226353004/diff/1/chrome/common/extensions/ch...
File chrome/common/extensions/chrome_extensions_client.cc (right):

https://codereview.chromium.org/1226353004/diff/1/chrome/common/extensions/ch...
chrome/common/extensions/chrome_extensions_client.cc:292:
api::ChromeGeneratedSchemas::IsGenerated(name);
This is the only meaningful non-Python/gyp/gypi/gn change I've made.

[Ken Rockot(use gerrit already), 2015-07-17 17:52:54]

On 2015/07/16 22:08:32, kalman wrote:
> Hey Ken, I haven't quite finished this patch, but sending out now to get some
> early feedback.
> 
> Does this look like the right thing to you? Seeing "core_api" everywhere was
> annoying me.
> 
> See that 1 comment for an example for how the code will change, apart from
mass
> rename from core_api --> api.
> 
> (It doesn't quite compile yet, but I need to head off)
> 
>
https://codereview.chromium.org/1226353004/diff/1/chrome/common/extensions/ch...
> File chrome/common/extensions/chrome_extensions_client.cc (right):
> 
>
https://codereview.chromium.org/1226353004/diff/1/chrome/common/extensions/ch...
> chrome/common/extensions/chrome_extensions_client.cc:292:
> api::ChromeGeneratedSchemas::IsGenerated(name);
> This is the only meaningful non-Python/gyp/gypi/gn change I've made.

Yes this looks like the right thing to do. yay.

[not at google - send to devlin, 2015-07-17 20:04:14]

Ready to review. Look at:
- gn[i] and gyp[i] files.
- anything in json_schema_compiler.
- the ExtensionsClient/ExtensionsBrowserClient implementations.

And a random smattering of other files for context. Everything else is basically
s/core_api/api/g.

[Ken Rockot(use gerrit already), 2015-07-20 20:11:32]

lgtm

[not at google - send to devlin, 2015-07-20 21:10:51]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2015-07-20 21:10:52]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/1226353004/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-20 21:11:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226353004/60001

[commit-bot: I haz the power, 2015-07-20 21:22:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-20 21:22:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[not at google - send to devlin, 2015-07-21 18:02:09]

kalman@chromium.org changed reviewers:
+ thakis@chromium.org

[not at google - send to devlin, 2015-07-21 18:02:11]

+thakis to review files in build/ directory.

I'm actually missing owners for these files:
    build/json_schema_api.gni
    build/json_schema_bundle_compile.gypi
    build/json_schema_bundle_registration_compile.gypi
    chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc
    chrome/browser/chromeos/policy/power_policy_browsertest.cc
    chrome/browser/signin/easy_unlock_app_manager_unittest.cc
    chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc

but consider the files in chrome/browser a TBR, they're just renaming "core_api"
--> "api". A happy accident of getting an lg from you will be an effective lg
for those files as well.

[not at google - send to devlin, 2015-07-22 16:19:39]

kalman@chromium.org changed reviewers:
+ dpranke@google.com
- thakis@chromium.org

[not at google - send to devlin, 2015-07-22 16:19:41]

thakis is out, dpranke could you have a look (see previous comment for files)?

[Dirk Pranke, 2015-07-22 21:29:12]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2015-07-22 21:29:13]

files in build/ lgtm.

[not at google - send to devlin, 2015-07-22 21:44:36]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-07-22 21:45:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226353004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1226353004/60001

[commit-bot: I haz the power, 2015-07-22 21:54:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-22 21:54:28]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[not at google - send to devlin, 2015-07-23 00:34:02]

The CQ bit was checked by kalman@chromium.org

[not at google - send to devlin, 2015-07-23 00:34:03]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/1226353004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2015-07-23 00:34:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226353004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1226353004/80001

[commit-bot: I haz the power, 2015-07-23 00:47:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-23 00:47:34]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[not at google - send to devlin, 2015-07-23 17:26:41]

TBR'd ben to pick up the renames to those other directories.

[not at google - send to devlin, 2015-07-23 17:26:52]

The CQ bit was checked by kalman@chromium.org

[commit-bot: I haz the power, 2015-07-23 17:28:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1226353004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1226353004/80001

[commit-bot: I haz the power, 2015-07-23 18:27:46]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-07-23 18:28:28]

Patchset 5 (id:??) landed as
https://crrev.com/e58e6223146f09405229146fce6c1bfe6b71e4ce
Cr-Commit-Position: refs/heads/master@{#340119}