extensions/common/manifest_handlers/externally_connectable.cc - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/manifest_handlers/externally_connectable.cc

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/common/manifest_handlers/content_capabilities_handler.cc ('k') | extensions/common/manifest_handlers/options_page_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/manifest_handlers/externally_connectable.cc

diff --git a/extensions/common/manifest_handlers/externally_connectable.cc b/extensions/common/manifest_handlers/externally_connectable.cc

index 1314c6d1cb0fa47b699aecf626353956489601d0..db0748c47e905f5ef445f8bd4522b2c1edf1a32c 100644

--- a/extensions/common/manifest_handlers/externally_connectable.cc

+++ b/extensions/common/manifest_handlers/externally_connectable.cc

@@ -37,7 +37,7 @@ const char kErrorWildcardHostsNotAllowed[] =

namespace keys = extensions::manifest_keys;

namespace errors = externally_connectable_errors;

-using core_api::extensions_manifest_types::ExternallyConnectable;

+using api::extensions_manifest_types::ExternallyConnectable;

namespace {