extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h - Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

Issue 1226353004: Generate all extension schema namespaces as "api" and instead vary the generated bundle names. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative/test_rules_registry.cc ('k') | extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

diff --git a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

index 6196129e8f468c6dab5ba48db03909b0878fe374..5baa8c41010ec9e8b1a5507805f719f12cf4691c 100644

--- a/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

+++ b/extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h

@@ -51,7 +51,7 @@ typedef DeclarativeRule<WebRequestCondition, WebRequestAction> WebRequestRule;

// Here is the high level overview of this functionality:

-// core_api::events::Rule consists of Conditions and Actions, these are

+// api::events::Rule consists of Conditions and Actions, these are

// represented as a WebRequestRule with WebRequestConditions and

// WebRequestRuleActions.

@@ -97,7 +97,7 @@ class WebRequestRulesRegistry : public RulesRegistry {

// Implementation of RulesRegistry:

std::string AddRulesImpl(

const std::string& extension_id,

- const std::vector<linked_ptr<core_api::events::Rule>>& rules) override;

+ const std::vector<linked_ptr<api::events::Rule>>& rules) override;

std::string RemoveRulesImpl(

const std::string& extension_id,

const std::vector<std::string>& rule_identifiers) override;